<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105471/">http://git.reviewboard.kde.org/r/105471/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Marijn is on vacation, and given the simple patch and obvious bug - i'd say ship it and backport</pre>
<br />
<p>- C.</p>
<br />
<p>On July 7th, 2012, 11:56 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Marijn Kruisselbrink.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 7, 2012, 11:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some mass rename a few years ago (d1fa9526) seems to have left a dirty trace in sheets/Style.cpp, it turned the strings "formula-hidden"/"protected formula-hidden" into "Formula.hidden"/"protected Formula.hidden". Which is wrong of course. And makes e.g. odf/ods/Financial_Report.ods from the calligratests fail.
Attached patch fixes the strings, and also adds a workaround for loading of files with the broken strings.
Okay to backport to 2.5?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoOdfWorkaround.h <span style="color: grey">(8672f22)</span></li>
<li>libs/flake/KoOdfWorkaround.cpp <span style="color: grey">(8d3d523)</span></li>
<li>sheets/Style.cpp <span style="color: grey">(7e32a29)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105471/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>