<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105464/">http://git.reviewboard.kde.org/r/105464/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 7th, 2012, 9:07 a.m., <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess this is because the bibliography stuff is going to use it? In any case, before moving a lot of code into libs, I would like to see that it uses the calligra coding style in matters of file names (KoConnection.cpp instead of connection.cpp, for instance), getting rid of the namespaces and references to Kexi.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well normally i would agree but this library is on a short life cycle, as it will be replaced by predicate</pre>
<br />
<p>- C.</p>
<br />
<p>On July 7th, 2012, 12:34 a.m., Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg, C. Boemann, Smit Patel, Dimitrios Tanis, and Oleg Kukharchuk.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated July 7, 2012, 12:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move core parts of KexiDB lib from kexi/kexidb to calligra/libs/db (libcalligradb) for reuse by Word's Biblio module and possibly other places in Calligra.
Details at http://community.kde.org/Kexi/KexiDB#libCalligraDB
* GUI- or Kexi-related bits such as validators are still in Kexi
* Only the SQLite3 driver is moved to libcalligradb, others stay within Kexi
** thus, calligra libs depend on the driver, i.e. depend on SQLite3 (this was the case already for Words and Kexi)
** calligra libs depend on ICU as well for proper unicode handling (which is dependency of Qt 5 anyway)
* Predicate library, as a Qt-only component, will replace functionality of the calligradb lib
* sqlitedump tool used for database for interactive database compacting stays in Kexi; if needed could be moved to libs/ too
* a few functions from libkexiutils moved to libcalligradb, so libkexiutils is not dependency
* for simplicity/API stability, namespace stays as KexiDB
* README.PACKAGERS file updated</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kexi and kexidbtest runs properly</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(33cdabb)</span></li>
<li>README.PACKAGERS <span style="color: grey">(277d0e7)</span></li>
<li>cmake/modules/FindCalligraSqlite.cmake <span style="color: grey">(be39e5f)</span></li>
<li>kexi/CMakeLists.txt <span style="color: grey">(a724a34)</span></li>
<li>kexi/core/CMakeLists.txt <span style="color: grey">(2b2a0bb)</span></li>
<li>kexi/core/KexiMainWindowIface.h <span style="color: grey">(797c2cb)</span></li>
<li>kexi/core/KexiRecentProjects.cpp <span style="color: grey">(d3e9921)</span></li>
<li>kexi/core/KexiView.cpp <span style="color: grey">(fd32219)</span></li>
<li>kexi/core/KexiWindow.cpp <span style="color: grey">(5b3bc11)</span></li>
<li>kexi/core/kexi.h <span style="color: grey">(b6eb4a3)</span></li>
<li>kexi/core/kexi.cpp <span style="color: grey">(4408e8b)</span></li>
<li>kexi/core/kexiblobbuffer.cpp <span style="color: grey">(37ede52)</span></li>
<li>kexi/core/kexidbconnectionset.h <span style="color: grey">(e47eaa3)</span></li>
<li>kexi/core/kexidbshortcutfile.cpp <span style="color: grey">(95c499b)</span></li>
<li>kexi/core/kexiguimsghandler.h <span style="color: grey">(91c6a2c)</span></li>
<li>kexi/core/kexiguimsghandler.cpp <span style="color: grey">(c1c2b80)</span></li>
<li>kexi/core/kexiinternalpart.cpp <span style="color: grey">(13a834a)</span></li>
<li>kexi/core/kexipart.h <span style="color: grey">(ad12383)</span></li>
<li>kexi/core/kexipart.cpp <span style="color: grey">(7ffe8896)</span></li>
<li>kexi/core/kexipartinfo.cpp <span style="color: grey">(a89cd38)</span></li>
<li>kexi/core/kexipartmanager.h <span style="color: grey">(474fb31c)</span></li>
<li>kexi/core/kexipartmanager.cpp <span style="color: grey">(050b051)</span></li>
<li>kexi/core/kexiproject.h <span style="color: grey">(e9e366b)</span></li>
<li>kexi/core/kexiproject.cpp <span style="color: grey">(1ce37ad)</span></li>
<li>kexi/core/kexiprojectconnectiondata.h <span style="color: grey">(a165bfe)</span></li>
<li>kexi/core/kexiprojectconnectiondata.cpp <span style="color: grey">(67cba7d)</span></li>
<li>kexi/core/kexiprojectdata.h <span style="color: grey">(49fbe74)</span></li>
<li>kexi/core/kexiprojectdata.cpp <span style="color: grey">(774e2e2)</span></li>
<li>kexi/core/kexiprojectset.h <span style="color: grey">(0c281dc)</span></li>
<li>kexi/core/kexiprojectset.cpp <span style="color: grey">(2ae1c2b)</span></li>
<li>kexi/core/kexisearchandreplaceiface.h <span style="color: grey">(ca99062)</span></li>
<li>kexi/core/kexistartupdata.cpp <span style="color: grey">(74a81e4)</span></li>
<li>kexi/core/kexitabledesignerinterface.h <span style="color: grey">(5859ee6)</span></li>
<li>kexi/core/kexitemplateloader.cpp <span style="color: grey">(901994c)</span></li>
<li>kexi/core/kexitextmsghandler.cpp <span style="color: grey">(31f1d0b)</span></li>
<li>kexi/formeditor/CMakeLists.txt <span style="color: grey">(bd5ca24)</span></li>
<li>kexi/formeditor/WidgetInfo.h <span style="color: grey">(8b66912)</span></li>
<li>kexi/formeditor/form.cpp <span style="color: grey">(5746780)</span></li>
<li>kexi/formeditor/kexiformeventhandler.cpp <span style="color: grey">(195a63f)</span></li>
<li>kexi/kexidb/CMakeLists.txt <span style="color: grey">(37ea839)</span></li>
<li>kexi/kexidb/RecordData.h <span style="color: grey">(074d3ba)</span></li>
<li>kexi/kexidb/RecordData.cpp <span style="color: grey">(03a6ddb)</span></li>
<li>kexi/kexidb/admin.h <span style="color: grey">(af28574)</span></li>
<li>kexi/kexidb/admin.cpp <span style="color: grey">(2e9e981)</span></li>
<li>kexi/kexidb/alter.h <span style="color: grey">(1d3d26e)</span></li>
<li>kexi/kexidb/alter.cpp <span style="color: grey">(784b93b)</span></li>
<li>kexi/kexidb/common.pro <span style="color: grey">(18235e2)</span></li>
<li>kexi/kexidb/connection.h <span style="color: grey">(e77d840)</span></li>
<li>kexi/kexidb/connection.cpp <span style="color: grey">(a81f4c1)</span></li>
<li>kexi/kexidb/connection_p.h <span style="color: grey">(b882267)</span></li>
<li>kexi/kexidb/connectiondata.h <span style="color: grey">(be7f472)</span></li>
<li>kexi/kexidb/connectiondata.cpp <span style="color: grey">(4c75f5c)</span></li>
<li>kexi/kexidb/cursor.h <span style="color: grey">(0dfdb17)</span></li>
<li>kexi/kexidb/cursor.cpp <span style="color: grey">(d7450a3)</span></li>
<li>kexi/kexidb/cursor_p.h <span style="color: grey">(16083e7)</span></li>
<li>kexi/kexidb/dbobjectnamevalidator.h <span style="color: grey">(fd3d763)</span></li>
<li>kexi/kexidb/dbobjectnamevalidator.cpp <span style="color: grey">(1d79c87)</span></li>
<li>kexi/kexidb/dbproperties.h <span style="color: grey">(69f718b)</span></li>
<li>kexi/kexidb/dbproperties.cpp <span style="color: grey">(2ee7fa4)</span></li>
<li>kexi/kexidb/driver.h <span style="color: grey">(d51a870)</span></li>
<li>kexi/kexidb/driver.cpp <span style="color: grey">(8ece2aa)</span></li>
<li>kexi/kexidb/driver_p.h <span style="color: grey">(67f312c)</span></li>
<li>kexi/kexidb/driver_p.cpp <span style="color: grey">(af400c6)</span></li>
<li>kexi/kexidb/drivermanager.h <span style="color: grey">(140be5c)</span></li>
<li>kexi/kexidb/drivermanager.cpp <span style="color: grey">(08729ab)</span></li>
<li>kexi/kexidb/drivermanager_p.h <span style="color: grey">(28eff57)</span></li>
<li>kexi/kexidb/drivers/CMakeLists.txt <span style="color: grey">(9e48942)</span></li>
<li>kexi/kexidb/drivers/mySQL/CMakeLists.txt <span style="color: grey">(747c337)</span></li>
<li>kexi/kexidb/drivers/mySQL/mysqlconnection.h <span style="color: grey">(cd69b53)</span></li>
<li>kexi/kexidb/drivers/mySQL/mysqlconnection.cpp <span style="color: grey">(dac326d)</span></li>
<li>kexi/kexidb/drivers/mySQL/mysqlconnection_p.h <span style="color: grey">(b29e721)</span></li>
<li>kexi/kexidb/drivers/mySQL/mysqlconnection_p.cpp <span style="color: grey">(98f7985)</span></li>
<li>kexi/kexidb/drivers/mySQL/mysqlcursor.h <span style="color: grey">(b3a8dcd)</span></li>
<li>kexi/kexidb/drivers/mySQL/mysqlcursor.cpp <span style="color: grey">(5e302db)</span></li>
<li>kexi/kexidb/drivers/mySQL/mysqldriver.h <span style="color: grey">(afab017)</span></li>
<li>kexi/kexidb/drivers/mySQL/mysqldriver.cpp <span style="color: grey">(90408b9)</span></li>
<li>kexi/kexidb/drivers/mySQL/mysqlpreparedstatement.h <span style="color: grey">(d2cba87)</span></li>
<li>kexi/kexidb/drivers/odbc/kodbcdriver.h <span style="color: grey">(03e0fb1)</span></li>
<li>kexi/kexidb/drivers/odbc/kodbcdriver.cpp <span style="color: grey">(f375e47)</span></li>
<li>kexi/kexidb/drivers/odbc/odbcconnection.h <span style="color: grey">(cd97d2c)</span></li>
<li>kexi/kexidb/drivers/odbc/odbcconnection.cpp <span style="color: grey">(300fde9)</span></li>
<li>kexi/kexidb/drivers/odbc/odbcconnection_p.h <span style="color: grey">(6124d9b)</span></li>
<li>kexi/kexidb/drivers/odbc/odbcconnection_p.cpp <span style="color: grey">(2ffbaa5)</span></li>
<li>kexi/kexidb/drivers/odbc/odbccursor.h <span style="color: grey">(afdaedd)</span></li>
<li>kexi/kexidb/drivers/odbc/odbccursor.cpp <span style="color: grey">(8fd2c7b)</span></li>
<li>kexi/kexidb/drivers/odbc/odbcdriver.h <span style="color: grey">(a9a1b8b)</span></li>
<li>kexi/kexidb/drivers/odbc/odbcdriver.cpp <span style="color: grey">(c7653af)</span></li>
<li>kexi/kexidb/drivers/odbc/odbcpreparedstatement.h <span style="color: grey">(1cb02dd)</span></li>
<li>kexi/kexidb/drivers/oracle/oracleconnection.h <span style="color: grey">(1dc9589)</span></li>
<li>kexi/kexidb/drivers/oracle/oracleconnection_p.h <span style="color: grey">(3c31c8c)</span></li>
<li>kexi/kexidb/drivers/oracle/oracleconnection_p.cpp <span style="color: grey">(22ff9fc)</span></li>
<li>kexi/kexidb/drivers/oracle/oraclecursor.h <span style="color: grey">(332b464)</span></li>
<li>kexi/kexidb/drivers/oracle/oraclecursor.cpp <span style="color: grey">(ebfce51)</span></li>
<li>kexi/kexidb/drivers/oracle/oracledriver.h <span style="color: grey">(0589f37)</span></li>
<li>kexi/kexidb/drivers/oracle/oracledriver.cpp <span style="color: grey">(0f7cb29)</span></li>
<li>kexi/kexidb/drivers/oracle/oraclepreparedstatement.h <span style="color: grey">(e09ffa6)</span></li>
<li>kexi/kexidb/drivers/pqxx/CMakeLists.txt <span style="color: grey">(06ed2ff)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxconnection.h <span style="color: grey">(2f6d6e9)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxconnection.cpp <span style="color: grey">(700b195)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxconnection_p.h <span style="color: grey">(9e66343)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxcursor.h <span style="color: grey">(8858b3f)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxcursor.cpp <span style="color: grey">(0086305)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxdriver.h <span style="color: grey">(c50b065)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxdriver.cpp <span style="color: grey">(3a47cf8)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxpreparedstatement.h <span style="color: grey">(ba0f860)</span></li>
<li>kexi/kexidb/drivers/sqlite/CMakeLists.txt <span style="color: grey">(6933562)</span></li>
<li>kexi/kexidb/drivers/sqlite/dump/CMakeLists.txt <span style="color: grey">(bf982f8)</span></li>
<li>kexi/kexidb/drivers/sqlite/dump/README <span style="color: grey">(ba4c33f)</span></li>
<li>kexi/kexidb/drivers/sqlite/dump/main.cpp <span style="color: grey">(98abfeb)</span></li>
<li>kexi/kexidb/drivers/sqlite/dump/shell.c <span style="color: grey">(d10d436)</span></li>
<li>kexi/kexidb/drivers/sqlite/icu/CMakeLists.txt <span style="color: grey">(fa81579)</span></li>
<li>kexi/kexidb/drivers/sqlite/icu/README.txt <span style="color: grey">(01291e6)</span></li>
<li>kexi/kexidb/drivers/sqlite/icu/icu.c <span style="color: grey">(60799c4)</span></li>
<li>kexi/kexidb/drivers/sqlite/icu/sqliteicu.h <span style="color: grey">(4c9a4f9)</span></li>
<li>kexi/kexidb/drivers/sqlite/kexidb_sqlite3driver.desktop <span style="color: grey">(4ff6cb7)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqliteadmin.h <span style="color: grey">(1a232c1)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqliteadmin.cpp <span style="color: grey">(8715d12)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqlitealter.cpp <span style="color: grey">(30c5ba0)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqliteconnection.h <span style="color: grey">(9d20806)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqliteconnection.cpp <span style="color: grey">(4877506)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqliteconnection_p.h <span style="color: grey">(ae701a2)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqlitecursor.h <span style="color: grey">(5860794)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqlitecursor.cpp <span style="color: grey">(cfc6102)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqlitedriver.h <span style="color: grey">(b745dfc)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqlitedriver.cpp <span style="color: grey">(7124ba9)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqlitekeywords.cpp <span style="color: grey">(735f446)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqlitepreparedstatement.h <span style="color: grey">(8411dfe)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqlitepreparedstatement.cpp <span style="color: grey">(ffb751e)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqlitevacuum.h <span style="color: grey">(d9a8cfd)</span></li>
<li>kexi/kexidb/drivers/sqlite/sqlitevacuum.cpp <span style="color: grey">(5c20482)</span></li>
<li>kexi/kexidb/drivers/sybase/CMakeLists.txt <span style="color: grey">(66c2c56)</span></li>
<li>kexi/kexidb/drivers/sybase/sybaseconnection.h <span style="color: grey">(876ed88)</span></li>
<li>kexi/kexidb/drivers/sybase/sybaseconnection.cpp <span style="color: grey">(2064afe)</span></li>
<li>kexi/kexidb/drivers/sybase/sybaseconnection_p.h <span style="color: grey">(8b50690)</span></li>
<li>kexi/kexidb/drivers/sybase/sybaseconnection_p.cpp <span style="color: grey">(aef7afb)</span></li>
<li>kexi/kexidb/drivers/sybase/sybasecursor.h <span style="color: grey">(3f1b200)</span></li>
<li>kexi/kexidb/drivers/sybase/sybasecursor.cpp <span style="color: grey">(29e3870)</span></li>
<li>kexi/kexidb/drivers/sybase/sybasedriver.cpp <span style="color: grey">(6262f83)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105464/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>