<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105458/">http://git.reviewboard.kde.org/r/105458/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice work, and ok to backport to 2.5 too</pre>
<br />
<p>- C.</p>
<br />
<p>On July 6th, 2012, 1:41 p.m., Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated July 6, 2012, 1:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For page backgrounds it happens that the image gets shown quite badly when in stretch mode is used. See bug report. When tesing the fix I found out that this effects quite a lot presentations. Not all as bad as in the bug report. With the patch all the images improve nicely.
Problem was that the images generated for the pattern background did not generate a image as big as needed but some fixed one that resulted in not so good looking background images.
The patch is quite big as 2 new parameters (KoViewConverter and KoShapePaintingContext) are added to the KoShapeBackground::paint method.
The KoShapePaintingContext is not yet used but this is needed for animations in stage that change the background color and as I was already at it I added it too.
OK to backport to 2.5?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the full set of cstester documents and only improvements found.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>karbon/ui/widgets/KarbonSmallStylePreview.cpp <span style="color: grey">(fb00a2c)</span></li>
<li>kexi/plugins/shapes/relationdesign/kexirelationdesignshape.h <span style="color: grey">(9cac7b9)</span></li>
<li>kexi/plugins/shapes/relationdesign/kexirelationdesignshape.cpp <span style="color: grey">(eba6931)</span></li>
<li>libs/flake/KoColorBackground.h <span style="color: grey">(6cf70d3)</span></li>
<li>libs/flake/KoColorBackground.cpp <span style="color: grey">(b400792)</span></li>
<li>libs/flake/KoGradientBackground.h <span style="color: grey">(5bbcc31)</span></li>
<li>libs/flake/KoGradientBackground.cpp <span style="color: grey">(df74f6b)</span></li>
<li>libs/flake/KoOdfGradientBackground.h <span style="color: grey">(89e12c0)</span></li>
<li>libs/flake/KoOdfGradientBackground.cpp <span style="color: grey">(f1a0022)</span></li>
<li>libs/flake/KoPathShape.h <span style="color: grey">(c2e3c19)</span></li>
<li>libs/flake/KoPathShape.cpp <span style="color: grey">(8c8167a)</span></li>
<li>libs/flake/KoPatternBackground.h <span style="color: grey">(f31b783)</span></li>
<li>libs/flake/KoPatternBackground.cpp <span style="color: grey">(13abc43)</span></li>
<li>libs/flake/KoShapeBackground.h <span style="color: grey">(7822c50)</span></li>
<li>libs/flake/KoShapeManager.cpp <span style="color: grey">(eeb733b)</span></li>
<li>libs/flake/KoUnavailShape.h <span style="color: grey">(eb5889d)</span></li>
<li>libs/flake/KoUnavailShape.cpp <span style="color: grey">(89b64fd)</span></li>
<li>libs/flake/tests/TestShapeBackgroundCommand.cpp <span style="color: grey">(67b4717)</span></li>
<li>libs/kopageapp/KoPAMasterPage.cpp <span style="color: grey">(42e9065)</span></li>
<li>libs/kopageapp/KoPAPage.h <span style="color: grey">(6a81b04)</span></li>
<li>libs/kopageapp/KoPAPage.cpp <span style="color: grey">(cd9c5f4)</span></li>
<li>libs/kopageapp/KoPAPageBase.h <span style="color: grey">(b9a5961)</span></li>
<li>libs/kopageapp/KoPAPageBase.cpp <span style="color: grey">(cd25030)</span></li>
<li>libs/kopageapp/KoPAViewModeNormal.cpp <span style="color: grey">(9212b8b)</span></li>
<li>plugins/artistictextshape/ArtisticTextShape.h <span style="color: grey">(05af662)</span></li>
<li>plugins/artistictextshape/ArtisticTextShape.cpp <span style="color: grey">(193d618)</span></li>
<li>plugins/chartshape/ChartShape.cpp <span style="color: grey">(e7a0954)</span></li>
<li>plugins/chartshape/Legend.cpp <span style="color: grey">(e74a77f)</span></li>
<li>plugins/chartshape/PlotArea.cpp <span style="color: grey">(8ec8274)</span></li>
<li>plugins/dockers/styledocker/StylePreview.cpp <span style="color: grey">(7ddee89)</span></li>
<li>plugins/textshape/TextShape.cpp <span style="color: grey">(a292690)</span></li>
<li>stage/part/KPrAnimationDirector.cpp <span style="color: grey">(17cc62b)</span></li>
<li>words/part/frames/KWFrameLayout.cpp <span style="color: grey">(8639a1b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105458/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>