<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105444/">http://git.reviewboard.kde.org/r/105444/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm not sure here. Iirc someone worked on this, knowing full well that odf doesn't support it. So I'm a little hesitant to say what we should do here.
Anyone else remember?</pre>
<br />
<p>- C.</p>
<br />
<p>On July 4th, 2012, 7:14 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and C. Boemann.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 4, 2012, 7:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The calligratests files
interoperability/wordprocessing/oowriter/oow_template_blank_musical_sheet.odt and
interoperability/wordprocessing/oowriter/oow_template_note_tracker.odt
fail with
--- 8< ---
INVALIDCONTENTXML: (unknown file):56: error: element "style:graphic-properties" not allowed here; expected the element end-tag or element "style:map", "style:paragraph-properties" or "style:text-properties"
(unknown file):60: error: element "style:graphic-properties" not allowed here; expected the element end-tag or element "style:map", "style:paragraph-properties" or "style:text-properties"
--- 8< ---
Reason is that style:graphic-properties are not to be used for table cell styles, only style:table-cell-properties. Which means no support for opacity with table cells at all on the saving/loading level. Should it be done in the Calligra namespace at least? But I also was not able to set any opacity with the Calligra UI, so perhaps there is no need for that yet.
Attached patch fixes both tests, by removing the code trying to load/save draw:opacity.
Okay to backport also to 2.5?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tools/scripts/validateODF.py reports no more errors on oow_template_note_tracker.odt and oow_template_blank_musical_sheet.odt</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/styles/KoTableCellStyle.cpp <span style="color: grey">(753d33c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105444/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>