<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105425/">http://git.reviewboard.kde.org/r/105425/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 3, 2012, 7:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">meh, one KoTemplate.cpp should not have been part of this patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">None of the Calligra parts uses Part::setWidget(...) or reimplements Part::widget().
So all KPart supporting programs like Konqueror will crash when they try to get the widget from the part (and expect to get one).
Just try yourself and do a Preview with... for some Calligra supported file.
Attached patch fixes that by simply removing the claim that CalligraParts are real KParts/ReadOnlyPart,KParts/ReadWritePart. By-effect is that sadly support for loading in Konqueror or KDevelop is gone, but well, effectively it already is. Hopefully the Parts->Doc/View refactoring from Boudewijn/Boemann can get us that back in the future?
Did not check, but guess this patch needs backporting to 2.5 as well.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tried to preview files with Konqueror & to load them with Calligra programs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>flow/part/flowpart.desktop <span style="color: grey">(fb17a3b)</span></li>
<li>karbon/data/karbonpart.desktop <span style="color: grey">(c5e0b0b)</span></li>
<li>krita/kritapart.desktop <span style="color: grey">(00fe3bf)</span></li>
<li>plan/planpart.desktop <span style="color: grey">(dfd3d0f)</span></li>
<li>plugins/chartshape/kchartpart.desktop <span style="color: grey">(027f628)</span></li>
<li>plugins/formulashape/kformulapart.desktop <span style="color: grey">(1a91584)</span></li>
<li>servicetypes/calligrapart.desktop <span style="color: grey">(ee551d8)</span></li>
<li>sheets/sheetspart.desktop <span style="color: grey">(5264778)</span></li>
<li>stage/part/stagepart.desktop <span style="color: grey">(e1f5ce6)</span></li>
<li>words/part/wordspart.desktop <span style="color: grey">(f0ca727)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105425/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>