<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105366/">http://git.reviewboard.kde.org/r/105366/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, so far everything is right, just the missing bits marked with //!qundo are TODO. We need to think how to test it all since we're not using undo/redo buttons now nor AlterTable machinery. Enabling kexi debug window could help. Definitely please include integration of this fix for 2.6 (at http://community.kde.org/Calligra/Feature_Plan#Kexi). So far please keep the patch is _dedicated_ branch and please name the branch in this review's 'branch' field.</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On July 2nd, 2012, 7:42 p.m., Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated July 2, 2012, 7:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ported tables plugin to kundo2.
The purpose of the review is for early feedback to ensure work is in the right direction. All crashes/problems will be fixed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opened an existing table and changed some property names</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/tables/kexitabledesignerview_p.cpp <span style="color: grey">(49af8fcfc7be103a841cf7a5ffd8abbd75e694bc)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview_p.h <span style="color: grey">(8f2744fc52d5902f89894bef107109ff09909236)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.h <span style="color: grey">(04710ffda0808563ebbfd73ecbbcddee72224267)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.cpp <span style="color: grey">(8ec956d73ca7874558ac5e3a1d5bd68a18c3c815)</span></li>
<li>kexi/plugins/tables/kexitabledesignercommands.cpp <span style="color: grey">(89bd10f939f17083cac0e9fa83c6c628fb555009)</span></li>
<li>kexi/plugins/tables/CMakeLists.txt <span style="color: grey">(a29b2b944d071149f92d46b8ecc09885d4604035)</span></li>
<li>kexi/plugins/tables/kexilookupcolumnpage.cpp <span style="color: grey">(4c459c41162400c3427cd04ef11a40f7b553f9a9)</span></li>
<li>kexi/plugins/tables/kexitabledesignercommands.h <span style="color: grey">(e906388055f508f0316b4fee3fdccb2e4379b8d8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105366/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>