<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103476/">http://git.reviewboard.kde.org/r/103476/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 23rd, 2011, 7:57 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103476/diff/1/?file=43914#file43914line41" style="color: black; font-weight: bold; text-decoration: underline;">stage/part/KPrPdfPrintJob.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="kt">bool</span> <span class="n">shouldBlock</span> <span class="o">=</span> <span class="p">(</span><span class="n">printingFlags</span> <span class="o">&</span> <span class="n">KoPrintJob</span><span class="o">::</span><span class="n">BlockingCall</span><span class="p">)</span> <span class="o">==</span> <span class="n">KoPrintJob</span><span class="o">::</span><span class="n">BlockingCall</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A general question. Should the print job not always blocking to avoid in consistencies when doing printing and manipulating it directly afterwards?</pre>
</blockquote>
<p>On June 19th, 2012, 1:16 p.m., <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, it's a refactoring of existing functionality. I am not sure how old the blocking flag is, but it predates a move to komain. I'm still in favour of this refactoring.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's from 2009 -- blocking was introduced to fix the print preview, but printing was always working in the background.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On December 19th, 2011, 5:33 p.m., Dan Leinir Turthra Jensen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Dan Leinir Turthra Jensen.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2011, 5:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Refactor out the pseudo-private blocking property in KoPrintingDialog
This is done by implementing a new flag for KoPrintJobs, which will allow the user to decide whether to block the call, and whether or not to show the progress dialog, making the logic inside the startPrintJob function clearer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Tried to print preview (the original reason for the pseudo-private property)
- Tried to print various documents to PDF
- Tried using adapted version of calligraconverter (which will be uploaded separately) which optionally hides the progress dialog in batch mode
(have no printer at my current location so could not test physical printing)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/kis_print_job.h <span style="color: grey">(387d64b)</span></li>
<li>krita/ui/kis_print_job.cpp <span style="color: grey">(4f33472)</span></li>
<li>libs/kopageapp/KoPAPrintJob.h <span style="color: grey">(057bb46)</span></li>
<li>libs/kopageapp/KoPAPrintJob.cpp <span style="color: grey">(ba069c7)</span></li>
<li>libs/main/KoMainWindow.h <span style="color: grey">(499b186)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(e1c3217)</span></li>
<li>libs/main/KoPrintJob.h <span style="color: grey">(bcbe894)</span></li>
<li>libs/main/KoPrintJob.cpp <span style="color: grey">(ff51adb)</span></li>
<li>libs/main/KoPrintingDialog.h <span style="color: grey">(f486620)</span></li>
<li>libs/main/KoPrintingDialog.cpp <span style="color: grey">(3ed83bd)</span></li>
<li>plan/libs/ui/kptganttview.h <span style="color: grey">(293d54a)</span></li>
<li>plan/libs/ui/kptganttview.cpp <span style="color: grey">(720111b)</span></li>
<li>plan/libs/ui/kptviewbase.h <span style="color: grey">(d3dc51b)</span></li>
<li>plan/libs/ui/kptviewbase.cpp <span style="color: grey">(95cda67)</span></li>
<li>stage/part/KPrPdfPrintJob.h <span style="color: grey">(b53e272)</span></li>
<li>stage/part/KPrPdfPrintJob.cpp <span style="color: grey">(39bdaf9)</span></li>
<li>tables/part/PrintJob.h <span style="color: grey">(93ba0f1)</span></li>
<li>tables/part/PrintJob.cpp <span style="color: grey">(1c6e710)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103476/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>