<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105213/">http://git.reviewboard.kde.org/r/105213/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 18th, 2012, 6:41 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some questions I have about the implementation:
- What is the need of the class KPrAnimationsDataModel? would it not be enought to use a pointer to the item in the KPrAnimationsTreeModel?
- In the KPrAnimationsTreeModel you copy the data which is in the animation steps into a new format. Do you think it would be possiblt to just use the animationSteps as they are as when it gets copied both structures need to be kept in sync which might turn out to be problematic
About the timeline. I agree with your proposal that the lower part should not be there by default but should popup when a animation is e.g. doubled clicked to edit it. It could then also contain the widget to modify the selected animation. With that there will be more space.
I found a crash. To reproduce:
- Open a presentation with shape animations
- Select the animation tool
- Select a shape with an animation
- Select the default tool
- Delete the currently selected shape.
- Select the animation tool
-> this results in a crash</pre>
</blockquote>
<p>On June 18th, 2012, 6:47 p.m., <b>Paul Mendez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Do you mean to use the same model for the two views. I was thinking in that, but I want to implement some edition features in the views (like drag and drop) and seems difficult to reuse the same things due to the basic view is a tree view and the Time Line View is a custom table View. However after start with the implementation of drag and drop I could have a better idea if I could merge the data models. At the moment they share the same substructure of data (The KPrCustomAnimationItem linked list), so there is not much duplication.
- I am going to think about that. At the moment KPrCustomAnimationItems keep pointers to KPrShapeAnimations, but I would need to update the Step, substep structure. Just to clarify, animations steps - substeps -KPrShapeAnimations relation, works like:
Step
|--> SubStep -> KPrShapeAnimation "On click Animation"
|--> SubStep -> KPrShapeAnimation "After Previous Animation"
|-> KPrShapeAnimation "With previous animation"
If things work like that It seems easy to replace the current linked list with the linked list of Steps - substeps. However I would like to have and intermediate object to use when loading predefined animations from the XML file. At the moment I think in two solutions: keep KPrCustomAnimationItem or just extend KPrShapeAnimation to hold temporal animations (animations without target). I have to think more about that.
- I think I fixed that yesterday. I can't reproduce the exact crash, but I found a bug that could be related, so I am going to work on that.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding the time line. I am going to move it to the popup dialog once finished the basic view.</pre>
<br />
<p>- Paul</p>
<br />
<p>On June 18th, 2012, 12:53 a.m., Paul Mendez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Paul Mendez.</div>
<p style="color: grey;"><i>Updated June 18, 2012, 12:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a docker to the Animation Tool to display information of shape animations. The docker has the following features:
- use a compound view with a time line for start, duration and animation type information.
- Has a button to play shape animations live preview.
- Layout edition buttons (edition features are not yet implemented)
Add a model to manage animations data information
Extend shapeAnimation class in order to save presentation-preset tags with information of animation type (entrance, exit, etc) and name.
The patch is only for a GSoC progress Review. Though being usable (and I hope stable), not yet finished.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>stage/part/CMakeLists.txt <span style="color: grey">(8617020a5e54ca640ef713257b94b4a8c9acf5fd)</span></li>
<li>stage/part/KPrAnimationsDataModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrAnimationsDataModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrAnimationsTimeLineView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrAnimationsTimeLineView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrAnimationsTreeModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrAnimationsTreeModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrCustomAnimationItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrCustomAnimationItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrTimeLineHeader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrTimeLineHeader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrTimeLineView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrTimeLineView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrViewModePreviewShapeAnimations.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrViewModePreviewShapeAnimations.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/animations/KPrAnimationBase.h <span style="color: grey">(b12bfab8d71a9a9a6dc0695d2ed95bc2e7326352)</span></li>
<li>stage/part/animations/KPrAnimationBase.cpp <span style="color: grey">(62bb2a2911c37962ab55a38ed0b753f7b390ce31)</span></li>
<li>stage/part/animations/KPrAnimationLoader.cpp <span style="color: grey">(b0680b401c86f743c15f4b9e6edea9c0de938eee)</span></li>
<li>stage/part/animations/KPrAnimationStep.h <span style="color: grey">(26a9fcec4b1d894ffe4d7d1dd2458a34c35e3d64)</span></li>
<li>stage/part/animations/KPrShapeAnimation.h <span style="color: grey">(f5d9ac3b796e75f16970f80245e1fbb6673fe1b9)</span></li>
<li>stage/part/animations/KPrShapeAnimation.cpp <span style="color: grey">(988cd14098d8ac1f9290b858540215d75d97f9f3)</span></li>
<li>stage/part/tools/animationtool/CMakeLists.txt <span style="color: grey">(5f5cb93f681ab95b0294de540e681d44ea9d27cb)</span></li>
<li>stage/part/tools/animationtool/KPrAnimationTool.h <span style="color: grey">(dbf12b9226f4da7b975d49ee19e5c7568cef7367)</span></li>
<li>stage/part/tools/animationtool/KPrAnimationTool.cpp <span style="color: grey">(99f3d5428f9a761d5376af6a5c1cf9a512266347)</span></li>
<li>stage/part/tools/animationtool/KPrShapeAnimationDocker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrShapeAnimationDocker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/hi32-action-after_previous.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/hi32-action-edit_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/hi32-action-onclick.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/hi32-action-unrecognized_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/hi32-action-with_previous.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105213/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>