<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105284/">http://git.reviewboard.kde.org/r/105284/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 18th, 2012, 7:51 a.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fyi -calligra at the end of icon names are most foten ignored in the naming scheme. If the icon engine cannot find icons with -calligra it removes that part and finds a more general icon.
However what this allows us is to have specialized calligra icons if we wish to. So not saying you change is wron, (we may not want the possibility of a specialized icon), but it's not wrong to have -calligra either
And in reply to jaraslaw: rather than renaming the icon we request we should rename the icon file to follow the fdo standard.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, had the "-postfix"-stripping-until-found systematic of the icon theme in mind when doing this.
But not another thing I might have just found out:
icons from locations added to the icon dirs to use only with KIconLoader::global()->addAppDir("calligra") seem to be checked only after those in the default locations. So whatever is installed into ${DATA_INSTALL_DIR}/calligra/icons will only be loaded if there is nothing in the default location.
Just check what is currently (also without this patch) displayed for the arrow icons set for the arrow shapes: go to the "Add Shape" docker and select the "Arrows" section. You will see the diamond-like arrow icons of at least the 4.8 theme.
I will update the patch with the arrow icons being renamed to the pattern mimetype-x-shape-arrow-{up,down,left,right}, following the pattern of the other pathshape icons. That should be the proper fix here.</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On June 17th, 2012, 8:54 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 17, 2012, 8:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes all those icon names referencing to non-existing icons for which there is a proper icon in Oxygen 4.3.5 or coming with Calligra itself (IMHO :))
Also renames ox22-action-arrow-right-calligra.png to hi22-action-arrow-right.png,
because it is no oxygen one, and after change aligned with other arrow icons.
Okay to also commit to master as well?
Dealt entries from the report of the koIcon script, commented how I propose to solve it:
arrow-down-calligra
plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:298
arrow-up-calligra
plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:265
arrow-left-calligra
plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:232
There is hi-version without -calligra prefix
Also renamed ox22-action-arrow-right-calligra.png to hi22-action-arrow-right.png,
because it is no oxygen one, and after change aligned with other arrow icons.
star
plugins/pathshapes/star/StarShapeFactory.cpp:40
14_layer_novisible
libs/kopageapp/KoPADocumentModel.cpp:314
14_layer_visible
libs/kopageapp/KoPADocumentModel.cpp:314
Oxygen from 4.3.5 has layer-visible-on and layer-visible-off icons, so use them.
fontsizeup
sheets/ui/CellToolBase.cpp:415
fontsizedown
sheets/ui/CellToolBase.cpp:421
There is also no icon in Kate/KWrite for that, so for now just use no icon
text
plugins/artistictextshape/ArtisticTextShapeFactory.cpp:33
Solved by reusing x-shape-text
open
plugins/pictureshape/PictureTool.cpp:110
plugins/staging/templateshape/TemplateTool.cpp:90
plugins/vectorshape/VectorTool.cpp:75
Solved by changing to document-open</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/KoPADocumentModel.cpp <span style="color: grey">(69feb88)</span></li>
<li>plugins/artistictextshape/ArtisticTextShapeFactory.cpp <span style="color: grey">(2438b20)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp <span style="color: grey">(d820c43)</span></li>
<li>plugins/pathshapes/pics/hi22-action-arrow-right.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pathshapes/pics/ox22-action-arrow-right-calligra.png <span style="color: grey">(dbb9e5a)</span></li>
<li>plugins/pathshapes/star/StarShapeFactory.cpp <span style="color: grey">(e6a9c6d)</span></li>
<li>plugins/pictureshape/PictureTool.cpp <span style="color: grey">(bf15751)</span></li>
<li>plugins/staging/templateshape/TemplateTool.cpp <span style="color: grey">(6373aa2)</span></li>
<li>plugins/vectorshape/VectorTool.cpp <span style="color: grey">(79742fd)</span></li>
<li>sheets/ui/CellToolBase.cpp <span style="color: grey">(89b79f9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105284/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>