<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105237/">http://git.reviewboard.kde.org/r/105237/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have some strange behaviours with your patch:
o When I load the file http://www.zagge.de/files/6_Slides.odp and go to page e.g. 5 and activate the connection tool not all connections poits of every shape is shown. Therefore it is not possible to start a connection from these point. I can however end the connection at those points.
o When clicking onto a connection I have the possibility to move the points where this connection is connected. However after that there seems to be no way back to create a new connection.
o When creating a new connection and after I started dragging from the first connection point in the odp given above I get very stange jumping of the connection to someplace where my cursor is not during dragging.</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On June 13th, 2012, 10:32 a.m., Yue Liu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Yue Liu.</div>
<p style="color: grey;"><i>Updated June 13, 2012, 10:32 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The original design to connection tool used several edit mode to manipulate connections and connection points, it works but user may not find out how to use it easily, so I added an option widget providing tool buttons to the usual actions user might want to use when manipulating connections, and disabled the double click to change edit mode feature in case user may accidentally enter unintended edit modes.
Other improvements are,
double click blank region to back to default tool, so now connection tool is consistent with path tool in this behavior,
added text box to new connectors created by default.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested in every application. connector path update not work in Words, but I think that's irrelevant with my patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoConnectionShape.h <span style="color: grey">(37984022f0154696d47385c5119f559978f9d9f2)</span></li>
<li>pics/oxygen/ox16-action-curve-connector.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/oxygen/ox16-action-lines-connector.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/oxygen/ox16-action-standard-connector.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/oxygen/ox16-action-straight-connector.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/CMakeLists.txt <span style="color: grey">(1f160106067dddba0d1ec0390669d31f66caf270)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionEditModeWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionEditModeWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionTool.h <span style="color: grey">(172eb7fd919b22ee60d2c3a594f09bebed43eea8)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionTool.cpp <span style="color: grey">(d95a34f02850719b13c7acbf5f57381fd53c6908)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105237/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>