<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105182/">http://git.reviewboard.kde.org/r/105182/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit bb65aa5fe7cc9121b04942c569e2d2c9ba1ca955 by Jaroslaw Staniek to branch connection-interaction-yue.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 9th, 2012, 9:35 a.m., Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated June 9, 2012, 9:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Set limit to 255 for Text type in MySQL Driver
MySQL Driver:
*set limit to 255 for Text type (VARCHAR)
*call "SET SESSION sql_mode='TRADITIONAL'" on opening database - needed to turn warnings about trimming string values into SQL errors</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with MySQL 5.5. Works because this commit reverts the behaviour of connection to previous state in case of MySQL. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=301136">301136</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/doc/dev/CHANGELOG-Kexi-js <span style="color: grey">(18e47c81f96b4382468369c59437dec54d573aa4)</span></li>
<li>kexi/kexidb/connection.cpp <span style="color: grey">(6ffabc64364a46a65aa65e2a29a4e2d657c51445)</span></li>
<li>kexi/kexidb/driver.cpp <span style="color: grey">(8b527c7c952e3b40546c10c52fc0a04dcf464341)</span></li>
<li>kexi/kexidb/driver_p.h <span style="color: grey">(b6d4af33f8a8279b5bdae1b1683770b91083ad98)</span></li>
<li>kexi/kexidb/drivers/mySQL/mysqlconnection_p.cpp <span style="color: grey">(7c4ea06c053fb77fbb7ba808564a1d9f24b6e4b8)</span></li>
<li>kexi/kexidb/drivers/mySQL/mysqldriver.cpp <span style="color: grey">(82edd6a678f27ce7b00bc90456ab5cb75b4e7683)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105182/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>