<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105240/">http://git.reviewboard.kde.org/r/105240/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 13th, 2012, 5:44 p.m., <b>Gopalakrishna Bhat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105240/diff/1/?file=67560#file67560line132" style="color: black; font-weight: bold; text-decoration: underline;">plugins/textshape/dialogs/EditFiltersDialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">EditFiltersDialog::EditFiltersDialog(QList<BibDbFilter*> *filters, QWidget *parent) :</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">132</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_filters</span><span class="p">(</span><span class="n">filters</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do not see that u use m_filters anywhere other than the constructor. Hence this can be removed.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I had removed this comment looks like it got published some how :( U can drop this</pre>
<br />
<p>- Gopalakrishna</p>
<br />
<p>On June 13th, 2012, 12:12 p.m., Smit Patel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Smit Patel.</div>
<p style="color: grey;"><i>Updated June 13, 2012, 12:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bibliography database UI.
1) create/load/save/edit table saved in SQLite file
2) Search in database
3) Apply custom filters to database
4) Integrated this UI with existing insert citation for edit/create cite in database</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(33cdabb)</span></li>
<li>libs/kotext/BibliographyGenerator.cpp <span style="color: grey">(15808cb)</span></li>
<li>libs/kotext/KoInlineCite.h <span style="color: grey">(df4a2e9)</span></li>
<li>libs/kotext/KoInlineCite.cpp <span style="color: grey">(6d949da)</span></li>
<li>libs/kotext/KoInlineTextObjectManager.cpp <span style="color: grey">(e82664d)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(b3e16ba)</span></li>
<li>plugins/chartshape/TODO <span style="color: grey">(94efb62)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(6253323)</span></li>
<li>plugins/textshape/ReferencesTool.h <span style="color: grey">(491b933)</span></li>
<li>plugins/textshape/ReferencesTool.cpp <span style="color: grey">(564b658)</span></li>
<li>plugins/textshape/dialogs/BibliographyDatabaseWindow.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/BibliographyDatabaseWindow.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/BibliographyDatabaseWindow.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/BibliographyDb.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/BibliographyDb.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/CitationInsertionDialog.h <span style="color: grey">(f5eac0b6)</span></li>
<li>plugins/textshape/dialogs/CitationInsertionDialog.cpp <span style="color: grey">(14f9429)</span></li>
<li>plugins/textshape/dialogs/CitationInsertionDialog.ui <span style="color: grey">(8f10f64)</span></li>
<li>plugins/textshape/dialogs/EditFiltersDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/EditFiltersDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/InsertCitationDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/InsertCitationDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/InsertCitationDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp <span style="color: grey">(2d1c1de)</span></li>
<li>plugins/textshape/dialogs/SimpleCitationBibliographyWidget.ui <span style="color: grey">(55699bb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105240/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>