<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105213/">http://git.reviewboard.kde.org/r/105213/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 11th, 2012, 9 p.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tried your branch :)
I'm wondering why both a timeline and the move up and down buttons. It seems to me that you now have two competing ways of representing time info.
-The horizontal expressed in seconds. And by definition we cannot express what happens in a timeline, because what happens changes with user interaction.
-The vertical that express interactive order and is controled by the move up and down buttons.
Also the first two colums are rather pointless. I assume they are just visible for debugging purposes?
Other than that the code looks reasonably fine to me.</pre>
</blockquote>
<p>On June 12th, 2012, 2:52 a.m., <b>Paul Mendez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks I really appreciate your suggestions and guide. At the moment (and for the project proposal), the time line is intended only to provide a quick edition and a visual representation of animation duration and delay time after trigger event. Up and down buttons control the real order of animations (In that sense probably “Time line” is not the better name for the widget).
I have thought also to use the time line to represent groups of related animations (Animations that trigger automatically after other animation or in parallel with other animation) but I have to work more in that idea.
Regarding the columns I was planning to remove the shape name column. Numbers were only to test how animations are loaded (And in case of implement the "group idea" for the Time Line, I want to use that column to add an extra visual aid to distinguish “groups” formed by “on click animations” and parallel or after previous animations).
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well just because something has been desribed in a gsoc proposal doesn't mean we should stick with it. As far as google is concerned we could even ask you to implement a chess game and let you pass that. As far as Stage is concerned I think it is a mistake to implement things that are clearly wrong. And showing the duration in a bar like that seems useless.
Dont forget the video I showed you (http://vimeo.com/36579366 from 29:00 and 10 min onward). It doesn't have a traditional timeline in sight. It has a series of snapshots, but not a traditional timeline. And that is because it's not all that useful to users. What matters is how the end result looks and feels, not if something happens at 1.6 or 1.7 seconds. That doesn't mean a timeline can't make sense but it's for sure not the most important thing.
I would really like us to think beyond the traditional. I would really like us to take a step ahead of the competition.
Now to me it seems like there are "events" and "animations". Events are slidestart and mouseclick. Animation is just like a traditional animation where things happen in parallel or sequence to one or more items. For every event there can be an animation.
This means that the ui in the video I linked is not enough, because it doesn't handle events. What we need is a way to create an animation for the various events and to edit that animation individually. So I propose that you change your ui to only have events as first level items. Then possibly later on we can have tree like foldout of a timeline for the animation below an event.
When a user has chosen an event he can edit the associated animation.
There will always be a slidestart event (which can't be deleted or moved). Initially there will also be a mouseclick event, but the user can delete it. The user can also add any number of mouseclick events, and all mouseclick events can be reordered.
There will be no such thing as a "timer event" as those are part of the animation under one of the events
For editing the animation I suggest to have something like in the linked video.
This is the kind ui that would really put us ahead of the competition, and it will be completely realistic for you to do, especially since you have already made a lot of the ground work. And even if you should not complete it in the gsoc timeframe, it's still much better than implementing a lot of stuff that is just wrong. I'm not your mentor, but I really don't think you should worry about failing as long as you work hard.
</pre>
<br />
<p>- C.</p>
<br />
<p>On June 11th, 2012, 6:40 a.m., Paul Mendez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Paul Mendez.</div>
<p style="color: grey;"><i>Updated June 11, 2012, 6:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a docker to the Animation Tool to display information of shape animations. The docker has the following features:
- use a compound view with a time line for start, duration and animation type information.
- Has a button to play shape animations live preview.
- Layout edition buttons (edition features are not yet implemented)
Add a model to manage animations data information
Extend shapeAnimation class in order to save presentation-preset tags with information of animation type (entrance, exit, etc) and name.
The patch is only for a GSoC progress Review. Though being usable (and I hope stable), not yet finished.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>stage/part/CMakeLists.txt <span style="color: grey">(8617020a5e54ca640ef713257b94b4a8c9acf5fd)</span></li>
<li>stage/part/KPrAnimationsDataModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrAnimationsDataModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrAnimationsTimeLineView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrAnimationsTimeLineView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrTimeLineHeader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrTimeLineHeader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrTimeLineView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrTimeLineView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrViewModePreviewShapeAnimations.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrViewModePreviewShapeAnimations.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/animations/KPrAnimationBase.h <span style="color: grey">(b12bfab8d71a9a9a6dc0695d2ed95bc2e7326352)</span></li>
<li>stage/part/animations/KPrAnimationBase.cpp <span style="color: grey">(62bb2a2911c37962ab55a38ed0b753f7b390ce31)</span></li>
<li>stage/part/animations/KPrAnimationLoader.cpp <span style="color: grey">(b0680b401c86f743c15f4b9e6edea9c0de938eee)</span></li>
<li>stage/part/animations/KPrAnimationStep.h <span style="color: grey">(26a9fcec4b1d894ffe4d7d1dd2458a34c35e3d64)</span></li>
<li>stage/part/animations/KPrShapeAnimation.h <span style="color: grey">(f5d9ac3b796e75f16970f80245e1fbb6673fe1b9)</span></li>
<li>stage/part/animations/KPrShapeAnimation.cpp <span style="color: grey">(988cd14098d8ac1f9290b858540215d75d97f9f3)</span></li>
<li>stage/part/tools/animationtool/CMakeLists.txt <span style="color: grey">(5f5cb93f681ab95b0294de540e681d44ea9d27cb)</span></li>
<li>stage/part/tools/animationtool/KPrAnimationTool.h <span style="color: grey">(dbf12b9226f4da7b975d49ee19e5c7568cef7367)</span></li>
<li>stage/part/tools/animationtool/KPrAnimationTool.cpp <span style="color: grey">(99f3d5428f9a761d5376af6a5c1cf9a512266347)</span></li>
<li>stage/part/tools/animationtool/KPrShapeAnimationDocker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrShapeAnimationDocker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/hi32-action-after_previous.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/hi32-action-edit_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/hi32-action-onclick.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/hi32-action-unrecognized_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/hi32-action-with_previous.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105213/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>