<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105164/">http://git.reviewboard.kde.org/r/105164/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 6th, 2012, 8:11 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105164/diff/1/?file=66483#file66483line274" style="color: black; font-weight: bold; text-decoration: underline;">kexi/plugins/reports/kexireportview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KexiReportView::slotPrintReport()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">238</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KGuiItem</span><span class="p">(</span><span class="s">"CSS"</span><span class="p">),</span> <span class="n">KGuiItem</span><span class="p">(</span><span class="s">"Table"</span><span class="p">))</span> <span class="o">==</span> <span class="n">KMessageBox</span><span class="o">::</span><span class="n">Yes</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">252</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KGuiItem</span><span class="p">(</span><span class="s">"CSS"</span><span class="p">),</span> <span class="n">KGuiItem</span><span class="p">(</span><span class="s">"Table"</span><span class="p">))</span> <span class="o">==</span> <span class="n">KMessageBox</span><span class="o">::</span><span class="n">Yes</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we're on that: maybe verbs are better?
If so: CSS -> Use CSS; Table -> Use Table
</pre>
</blockquote>
<p>On June 7th, 2012, 12:12 a.m., <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, agree that could be improved as well, so picked up your proposal. Also modified the message slightly (give CSS reference, make relative clauses non-defining).
No idea about title, just that old "Styles" is not perfect.</pre>
</blockquote>
<p>On June 11th, 2012, 8:26 p.m., <b>Adam Pigg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How about 'Export Format' or 'Export Style' ?</pre>
</blockquote>
<p>On June 11th, 2012, 9:02 p.m., <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tried that, but then I found out that to me again 'Export Report as Web Page', like the window title in the file selector, makes it more obvious that this dialog is still part of the same process. (And in a perfect world this dialog and the file selector one would be just subdialogs in an export wizard, but that improvement should not be part of this patch I think).
Would you agree to this reasoning?
Besides that I do not have a strong opinion, whatever you like more as title is fine with me.</pre>
</blockquote>
<p>On June 11th, 2012, 9:12 p.m., <b>Adam Pigg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Im easy going, and would rather see this in before the freeze. I have no strong opinion, but yes, a wizard would look nicer in the future.</pre>
</blockquote>
<p>On June 11th, 2012, 9:35 p.m., <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So... still no decision. :)
Shall I just decide? Or can you give your okay to 'Export Report as Web Page' as title and the updated dialog text (as in the current diff), so I feel good on committing?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You have my Ok for that :) #feelgood</pre>
<br />
<p>- Adam</p>
<br />
<p>On June 7th, 2012, 12:13 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Adam Pigg.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 7, 2012, 12:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See summary. In detail the patch does:
* use "Export" instead of "Save" everywhere
* give hint to used file formats in tooltip/whatsthis
* use same phrases with all formats
Like that solution?
I was also tempted to turn the export buttons into a dropdown menu, to make the toolbar less cluttered. No idea if that would clash with any Kexi UI guidelines...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Exported to all three formats, incl. overwriting files or not.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/doc/dev/CHANGELOG-Kexi-js <span style="color: grey">(f4c055c)</span></li>
<li>kexi/plugins/reports/kexireportview.h <span style="color: grey">(d119a86)</span></li>
<li>kexi/plugins/reports/kexireportview.cpp <span style="color: grey">(0482984)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105164/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>