<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103538/">http://git.reviewboard.kde.org/r/103538/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 10th, 2012, 4:12 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I could reproduce the blank slide show again but I don't know yet how to do that. Will investigate more.
I found a way that can make Calligra Stage crash. To reproduce:
o Have a slide show with more then one slide.
o Open Slide Sorter View
o Go to the last slide so that the icons are shown
o Press the delete button
-> the buttons are still shown even if there is no more slide (should be fixed)
o Press the delete button again
-> crash.</pre>
</blockquote>
<p>On June 10th, 2012, 3:10 p.m., <b>Paul Mendez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am going to work in the second bug. Regarding the first I haven't found yet how it could happen. The code just set the activePage and then call the KPrView method to start the presentation. So, It's almost the same code of the normal view.</pre>
</blockquote>
<p>On June 10th, 2012, 3:17 p.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sounds like something i may have solved in my canvas patch. Maybe you should postpone fixing until my patch is in master. (or at least try and apply and use my patch, to see)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe, but I couldn't reproduce the bug so, I can't test if it's connected to your patch.</pre>
<br />
<p>- Paul</p>
<br />
<p>On June 8th, 2012, 6:32 p.m., Paul Mendez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Paul Mendez.</div>
<p style="color: grey;"><i>Updated June 8, 2012, 6:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stage slides sorter has +/- buttons that appear when you move the mouse over an item to allow you select
or deselect multiple items without using the keyboard. This patch add extra actions (remove/duplicate slide and start slideshow from here)
like gwenview, digikam quick actions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">build and run</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/KoPADocumentStructureDocker.h <span style="color: grey">(c49c429c6c0b8a11f0c024bce1accc2a7203fcff)</span></li>
<li>libs/kopageapp/KoPADocumentStructureDocker.cpp <span style="color: grey">(7b31e5423db47955df6af9e2bb8ba3897895c61f)</span></li>
<li>libs/widgets/CMakeLists.txt <span style="color: grey">(9c25397ca1c475a90b94f5c188fb0cdaf3f39373)</span></li>
<li>libs/widgets/KoContextBarButton.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoContextBarButton.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoSelectionManager.h <span style="color: grey">(a2db231db64982b836e67f3d3d40dca468aa0d6d)</span></li>
<li>libs/widgets/KoSelectionManager.cpp <span style="color: grey">(23d0d88f951d701b82b43970a0f9d58043f96b52)</span></li>
<li>libs/widgets/KoSelectionToggle.h <span style="color: grey">(e83409fcded1cb2a7ef9fe0919a06308903aa9c0)</span></li>
<li>libs/widgets/KoSelectionToggle.cpp <span style="color: grey">(6ad6866c857761aa2d2b0becd42db7e980e1e996)</span></li>
<li>libs/widgets/KoViewItemContextBar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoViewItemContextBar.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrSlidesSorterDocumentModel.cpp <span style="color: grey">(74e7e7b98cec9cef720a81a030604ad7e98859bf)</span></li>
<li>stage/part/KPrViewModeSlidesSorter.h <span style="color: grey">(705fd2a9cd6286ba12fe6836f622bf4ceda51367)</span></li>
<li>stage/part/KPrViewModeSlidesSorter.cpp <span style="color: grey">(16d0bc051aed66a181b9f8479eca203fc14a6174)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103538/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>