<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105153/">http://git.reviewboard.kde.org/r/105153/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 940c2833f1ef67f496a1f47c6066d3e56844c7d7 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 5th, 2012, 4:30 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Thorsten Zachmann.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 5, 2012, 4:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the option widget of the background tool would be improved with the attached patch, at least for me it would be more obvious what it does and how to use it. Most important are to state that this (only) about the background of the whole page/slide/document, not normal shapes, and to disable the "Set image..." button if the background of the master slide should be used.
Still not solved: mouse cursor always shows not-allowed cursor.
Commit message is:
Improve page background tool option widget
* disable "Set image..." button if master page should be used
* add hint to use Stroke and Fill docker for color
* improve all texts slightly
* talk about slide or page depending of page type
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Edited backgrounds of masterpage and normal pages both in Stage and Flow.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui <span style="color: grey">(ed0c271)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp <span style="color: grey">(29fd22e)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp <span style="color: grey">(92ac030)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.h <span style="color: grey">(5888189)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp <span style="color: grey">(332dfb8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105153/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105153/s/595/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/06/05/SlideBackgroundToolOptionWidget_400x100.png" style="border: 1px black solid;" alt="New tool options design, here for slides" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>