<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105187/">http://git.reviewboard.kde.org/r/105187/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated June 9, 2012, 1:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rewrote all list items to use newly defined roles
Removed event filter and made 3rd column display correctly
Not aware of any bugs at the moment</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rewrote all list-items using newly defined roles Fixed visibility of 3rd column without using event filter</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rewrote all list-items using newly defined roles Fixed visibility of 3rd column without using event filter
Remove unused sorting code
Allow to not set the project model to not searchable
This prevents multiple models being added when not required.
Add back the current form action
Action now created properly and wors on form buttons
Also fixed crash in project navigator
Use the part class correctly
Inital port away from Q3/K3
Not fully functioning yet, but compiles and runs
Unused files removed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles Ok
Dialog displays Ok except 3rd column is initially the wrong size (fixes welcome)
Tested nearly all combinations of action, and that the save/load Ok, and that the actions still work in data mode.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/formeditor/kexiactionselectiondialog.h <span style="color: grey">(7e2d63befc4c4f8ff160bf5ab897024f63f6f590)</span></li>
<li>kexi/formeditor/kexiactionselectiondialog.cpp <span style="color: grey">(15e59d6effe535bfe433d7e274c9e6b49ec79744)</span></li>
<li>kexi/formeditor/kexiactionselectiondialog_p.h <span style="color: grey">(8e2a1fe6820b1e41267ef50fb01aa47d70073cf1)</span></li>
<li>kexi/widget/CMakeLists.txt <span style="color: grey">(c4106a3be823a0e54d21ecf5a2bcf24bb8ab246e)</span></li>
<li>kexi/widget/navigator/KexiProjectListView.h <span style="color: grey">(755579bc5c57f187829f7ab3c6c49e204299524e)</span></li>
<li>kexi/widget/navigator/KexiProjectListView.cpp <span style="color: grey">(127ac941e3958c6540593acceab6abd9928bec82)</span></li>
<li>kexi/widget/navigator/KexiProjectListViewItem.h <span style="color: grey">(88a515465ea1c0ed62d23e3ce39bff00a467af19)</span></li>
<li>kexi/widget/navigator/KexiProjectListViewItem.cpp <span style="color: grey">(540aaeec5082bcf2952243ae4a7367a971a0b4a8)</span></li>
<li>kexi/widget/navigator/KexiProjectListView_p.h <span style="color: grey">(9d7b678589937b398d18ef92be676ae382b7210d)</span></li>
<li>kexi/widget/navigator/KexiProjectNavigator.h <span style="color: grey">(009ff78d4d3c9417aa90247da48601406ca06149)</span></li>
<li>kexi/widget/navigator/KexiProjectNavigator.cpp <span style="color: grey">(095422fb149ea76a2c566d66a3412e92c855bddf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105187/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>