<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105180/">http://git.reviewboard.kde.org/r/105180/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 8th, 2012, 5:23 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please commit after fixing the details I noticied. If I miss someting on the inline stuff lets discuss it before committing.
One thing I noticed which is not due to your code but only visible when your code is there is that if you enter the first/last page in the widget the actions do not get enabled/disabled and therefore it shows the old state of the actions, e.g. when entering the last page the next and last action should be disabled and the first/previous should be enabled.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, the inlining was only there for historic reasons, and me too lazy to move over into the cpp file, after everything worked :))
Well, not everything works, as you pointed out, did not catch that before. Looking into the kopa code handling setting the active page I have not yet seen why the action updating is not reached in that case :/</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On June 7th, 2012, 6:14 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 7, 2012, 6:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently in Stage/Flow the status bar just has a read-only display for current page number and pages count.
Which also does not tell if the current pages are Master pages or not.
Attached patch fixes that, by turning the label into a display that turns into an editor, like the zoom controller.
Commit log:
It has 2 states:
in first state it displays
* type of slide/page (incl. if Master one)
* the number of the current page/slide
* the number of the page/slide count
in second state it offers control to
* go to first/previous/next/last slide/page
* go by entered number to slide/page
Does not use the icons of the original go* actions, as they look to complex</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used in Flow and Stage.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(a353892)</span></li>
<li>libs/kopageapp/KoPAView.h <span style="color: grey">(01fbdf1)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(6fccdb0)</span></li>
<li>libs/kopageapp/widgets/KoPageNavigator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kopageapp/widgets/KoPageNavigator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kopageapp/widgets/KoPageNavigatorButton.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kopageapp/widgets/KoPageNavigatorButton_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105180/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105180/s/600/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/06/07/PageNavigatorDisplay_400x100.png" style="border: 1px black solid;" alt="Display mode" /></a>
<a href="http://git.reviewboard.kde.org/r/105180/s/601/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/06/07/PageNavigatorEdit_400x100.png" style="border: 1px black solid;" alt="Edit mode" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>