<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103538/">http://git.reviewboard.kde.org/r/103538/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One think I noted is that when you select a slide by pressing plus or if you deselect a slide by pressing minus the icon does not change to minus/plus and you first need to leave and enter the slide again before you can change the selection.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103538/diff/3/?file=66768#file66768line748" style="color: black; font-weight: bold; text-decoration: underline;">stage/part/KPrViewModeSlidesSorter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KPrViewModeSlidesSorter::contextBarDuplicateSlide()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">748</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_slidesSorterModel</span><span class="o">-></span><span class="n">copySlides</span><span class="p">(</span><span class="n">slides</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">749</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">editPaste</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please move into the if block. Also move the slides into the if block.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103538/diff/3/?file=66768#file66768line759" style="color: black; font-weight: bold; text-decoration: underline;">stage/part/KPrViewModeSlidesSorter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KPrViewModeSlidesSorter::contextBarDuplicateSlide()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">759</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_slidesSorterModel</span><span class="o">-></span><span class="n">removeSlides</span><span class="p">(</span><span class="n">slides</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please move into the if block as it is only usefull if there was a page. Also the QList init can be moved to the if block</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103538/diff/3/?file=66768#file66768line762" style="color: black; font-weight: bold; text-decoration: underline;">stage/part/KPrViewModeSlidesSorter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KPrViewModeSlidesSorter::contextBarDuplicateSlide()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">762</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KPrViewModeSlidesSorter</span><span class="o">::</span><span class="n">contextBarStartSlideshow</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Starting a presentation does not work for me. Not sure what is wrong but I only get an empty white page when I start the presentation. Starting a presentation from the normal view works without a problem
</pre>
</div>
<br />
<p>- Thorsten</p>
<br />
<p>On June 8th, 2012, 6:03 a.m., Paul Mendez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Paul Mendez.</div>
<p style="color: grey;"><i>Updated June 8, 2012, 6:03 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stage slides sorter has +/- buttons that appear when you move the mouse over an item to allow you select
or deselect multiple items without using the keyboard. This patch add extra actions (remove/duplicate slide and start slideshow from here)
like gwenview, digikam quick actions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">build and run</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/KoPADocumentStructureDocker.h <span style="color: grey">(c49c429c6c0b8a11f0c024bce1accc2a7203fcff)</span></li>
<li>libs/kopageapp/KoPADocumentStructureDocker.cpp <span style="color: grey">(7b31e5423db47955df6af9e2bb8ba3897895c61f)</span></li>
<li>libs/widgets/CMakeLists.txt <span style="color: grey">(9c25397ca1c475a90b94f5c188fb0cdaf3f39373)</span></li>
<li>libs/widgets/KoContextBarButton.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoContextBarButton.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoSelectionManager.h <span style="color: grey">(a2db231db64982b836e67f3d3d40dca468aa0d6d)</span></li>
<li>libs/widgets/KoSelectionManager.cpp <span style="color: grey">(23d0d88f951d701b82b43970a0f9d58043f96b52)</span></li>
<li>libs/widgets/KoSelectionToggle.h <span style="color: grey">(e83409fcded1cb2a7ef9fe0919a06308903aa9c0)</span></li>
<li>libs/widgets/KoSelectionToggle.cpp <span style="color: grey">(6ad6866c857761aa2d2b0becd42db7e980e1e996)</span></li>
<li>libs/widgets/KoViewItemContextBar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoViewItemContextBar.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrSlidesSorterDocumentModel.cpp <span style="color: grey">(74e7e7b98cec9cef720a81a030604ad7e98859bf)</span></li>
<li>stage/part/KPrViewModeSlidesSorter.h <span style="color: grey">(705fd2a9cd6286ba12fe6836f622bf4ceda51367)</span></li>
<li>stage/part/KPrViewModeSlidesSorter.cpp <span style="color: grey">(16d0bc051aed66a181b9f8479eca203fc14a6174)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103538/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>