<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104708/">http://git.reviewboard.kde.org/r/104708/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here is the result of some more testing. Thanks to boemann for the check list.
> ----------------------------------------
> open blank document
> then load a file (replacing the blank document)
> check that the formula docker still works
This does not work. After opening the new file the cell editor is disabled. If
I double click on a cell it's still disabled. It's possible to edit the cell
in the cell itself though. After clicking on the default tool after these
tests, sheets crashed.
> open blank document
> small edit
> close document (template choose comes up again)
> then load a file (or choose a blank document)
> check that the formula docker still works
Crash on loading the new file
> open blank document
> small edit
> create new view
> check that the formula docker still works (in both views)
This works
> open blank document
> small edit
> then load a file (opens second window)
> check that the formula docker still works (in both windows)
This works
</pre>
<br />
<p>- Inge</p>
<br />
<p>On April 24th, 2012, 5:32 a.m., Marijn Kruisselbrink wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Marijn Kruisselbrink.</div>
<p style="color: grey;"><i>Updated April 24, 2012, 5:32 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This changes to UI of Calligra Sheets a bit by moving the cell editor widget out of the CellTool and instead have it as a separate docker. On top of that there are several new option widgets for the cell tool that provide common formatting options.
I've also changed the KoToolDocker a tiny bit, by changing the scroll area in it to not be able to get keyboard focus, at least for these new dockers that is preferred, I'm not sure if there are any other tool option widgets/use cases where you would want the scroll area containing the tool option widgets to be able to get keyboard focus?
Please test (also available in the tables-uirefactor-mek branch) and see if anything weird is happening since it is a fairly big change.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/KoToolDocker.cpp <span style="color: grey">(44ce789)</span></li>
<li>sheets/CMakeLists.txt <span style="color: grey">(5355719)</span></li>
<li>sheets/Messages.sh <span style="color: grey">(e636ac1)</span></li>
<li>sheets/part/CanvasItem.h <span style="color: grey">(41acefe)</span></li>
<li>sheets/part/CanvasItem.cpp <span style="color: grey">(c5ccba3)</span></li>
<li>sheets/part/Factory.cpp <span style="color: grey">(fb612da)</span></li>
<li>sheets/part/View.h <span style="color: grey">(5322e43)</span></li>
<li>sheets/part/View.cpp <span style="color: grey">(5c11f98)</span></li>
<li>sheets/ui/ActionOptionWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sheets/ui/ActionOptionWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sheets/ui/CellEditorDocker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sheets/ui/CellEditorDocker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sheets/ui/CellToolBase.h <span style="color: grey">(aa3a094)</span></li>
<li>sheets/ui/CellToolBase.cpp <span style="color: grey">(33f2d29)</span></li>
<li>sheets/ui/CellToolBase_p.h <span style="color: grey">(7750a4a)</span></li>
<li>sheets/ui/CellToolBase_p.cpp <span style="color: grey">(0cba586)</span></li>
<li>sheets/ui/CellToolOptionWidget.h <span style="color: grey">(c46b7df)</span></li>
<li>sheets/ui/CellToolOptionWidget.cpp <span style="color: grey">(4a1d068)</span></li>
<li>sheets/ui/CellToolOptionWidgets.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>sheets/ui/ExternalEditor.h <span style="color: grey">(ab3ee6d)</span></li>
<li>sheets/ui/ExternalEditor.cpp <span style="color: grey">(e9f8781)</span></li>
<li>sheets/ui/LocationComboBox.h <span style="color: grey">(e666ada)</span></li>
<li>sheets/ui/LocationComboBox.cpp <span style="color: grey">(6215039)</span></li>
<li>sheets/ui/Selection.h <span style="color: grey">(baa9cdf)</span></li>
<li>sheets/ui/Selection.cpp <span style="color: grey">(316a2fc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104708/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>