<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104992/">http://git.reviewboard.kde.org/r/104992/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks like a good start. The only thing I didn't understand was the kritarc thing.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104992/diff/1/?file=64940#file64940line2" style="color: black; font-weight: bold; text-decoration: underline;">krita/data/kritarc</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">WantExportConfirmation=false</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this relevant to this patch?</pre>
</div>
<br />
<p>- Inge</p>
<br />
<p>On May 19th, 2012, 9:25 a.m., Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated May 19, 2012, 9:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch combines several git commits and together cleans up the KoDocument interface, preparatory to removing the gui dependencies from KoDocument.
Summary:
* remove KoUnavail
* move wantExportConfirmation to a configuration setting
* move the static service handling to the KoServiceProvider class
* remove KoDocumentOdf::saveChildrenOdf (which was not not used)
* remove KoDocument::saveChilrden (was called in sheets and kounavail, but didn't do anything in sheets)
* remove all traces of widget embedding and single view mode
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ea68694)</span></li>
<li>flow/part/FlowDocument.h <span style="color: grey">(f4a580d)</span></li>
<li>flow/part/FlowDocument.cpp <span style="color: grey">(cf016a3)</span></li>
<li>flow/part/FlowFactory.cpp <span style="color: grey">(15431c6)</span></li>
<li>interfaces/koChart.h <span style="color: grey">(57be5c1)</span></li>
<li>interfaces/koChart.cc <span style="color: grey">(d07dcde)</span></li>
<li>karbon/ui/KarbonFactory.cpp <span style="color: grey">(5b21f2e)</span></li>
<li>karbon/ui/KarbonPart.h <span style="color: grey">(aa28784)</span></li>
<li>karbon/ui/KarbonPart.cpp <span style="color: grey">(e75a0ef)</span></li>
<li>kounavail/CMakeLists.txt <span style="color: grey">(8c71437)</span></li>
<li>kounavail/Messages.sh <span style="color: grey">(9b90c78)</span></li>
<li>kounavail/README <span style="color: grey">(426cf0b)</span></li>
<li>kounavail/kounavail.cc <span style="color: grey">(0cb08a3)</span></li>
<li>kounavail/kounavail.desktop <span style="color: grey">(70f140d)</span></li>
<li>kounavail/kounavail.h <span style="color: grey">(5bb4004)</span></li>
<li>kounavail/test-kounavail.kwd <span style="color: grey">(a072ffb)</span></li>
<li>kounavail/test-kounavail2.kwd <span style="color: grey">(1bee4f0)</span></li>
<li>krita/data/kritarc <span style="color: grey">(7235373)</span></li>
<li>krita/ui/kis_doc2.h <span style="color: grey">(ef0413b)</span></li>
<li>krita/ui/kis_doc2.cc <span style="color: grey">(01752c1)</span></li>
<li>krita/ui/kis_factory2.cc <span style="color: grey">(83c2bec)</span></li>
<li>krita/ui/kis_selection_manager.cc <span style="color: grey">(f9cb00c)</span></li>
<li>libs/kopageapp/KoPADocument.h <span style="color: grey">(91457a8)</span></li>
<li>libs/kopageapp/KoPADocument.cpp <span style="color: grey">(eedc136)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(4d13dfa)</span></li>
<li>libs/kopageapp/tests/PAMock.h <span style="color: grey">(bad1951)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(c6932fd)</span></li>
<li>libs/main/KoApplication.cpp <span style="color: grey">(a7352cf)</span></li>
<li>libs/main/KoDocument.h <span style="color: grey">(5daa007)</span></li>
<li>libs/main/KoDocument.cpp <span style="color: grey">(03086b3)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(8775981)</span></li>
<li>libs/main/KoServiceProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/KoServiceProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/KoVersionDialog.cpp <span style="color: grey">(eeb17d0)</span></li>
<li>libs/main/KoView.cpp <span style="color: grey">(a3f75d0)</span></li>
<li>libs/odf/KoOdfDocument.h <span style="color: grey">(51b0c2c)</span></li>
<li>libs/odf/KoOdfDocument.cpp <span style="color: grey">(f08d254)</span></li>
<li>plan/kptfactory.cpp <span style="color: grey">(4837d19)</span></li>
<li>plan/kptpart.h <span style="color: grey">(4edba32)</span></li>
<li>plan/kptpart.cpp <span style="color: grey">(56a2847)</span></li>
<li>plan/kptview.cpp <span style="color: grey">(c9175ae)</span></li>
<li>plan/libs/ui/kptperteditor.cpp <span style="color: grey">(9f37b6e)</span></li>
<li>plan/plugins/scripting/Module.cpp <span style="color: grey">(f44b071)</span></li>
<li>plugins/formulashape/FormulaDocument.h <span style="color: grey">(7fb21a0)</span></li>
<li>plugins/formulashape/FormulaDocument.cpp <span style="color: grey">(39bf132)</span></li>
<li>sheets/DocBase.h <span style="color: grey">(2edfca3)</span></li>
<li>sheets/DocBase.cpp <span style="color: grey">(aaf57d2)</span></li>
<li>sheets/Map.h <span style="color: grey">(da71304)</span></li>
<li>sheets/Map.cpp <span style="color: grey">(72245b4)</span></li>
<li>sheets/Sheet.h <span style="color: grey">(250f944)</span></li>
<li>sheets/Sheet.cpp <span style="color: grey">(09ff5b8)</span></li>
<li>sheets/part/Doc.h <span style="color: grey">(3b08cee)</span></li>
<li>sheets/part/Doc.cpp <span style="color: grey">(e80fad2)</span></li>
<li>sheets/part/Factory.cpp <span style="color: grey">(fb612da)</span></li>
<li>sheets/plugins/scripting/ScriptingModule.cpp <span style="color: grey">(d0d8535)</span></li>
<li>stage/part/KPrDocument.h <span style="color: grey">(d32ad26)</span></li>
<li>stage/part/KPrDocument.cpp <span style="color: grey">(3cb0858)</span></li>
<li>stage/part/KPrFactory.cpp <span style="color: grey">(45086d1)</span></li>
<li>stage/part/tests/PAMock.h <span style="color: grey">(eac4c88)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(eb09e16)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(0ab9b42)</span></li>
<li>words/part/KWFactory.cpp <span style="color: grey">(cc369f5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104992/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>