<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104928/">http://git.reviewboard.kde.org/r/104928/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The resizing of the canvas works now partly.
o When resizing the canvas flickers quite a lot, more then I think it should.
The canvas is not going only in one direction but it is is jumping back and forth
This seems to get fixed if I remove the following code
if (!forceUpdate) {
// if due to shape movement we change the scroll bar so the page itself
// doesn't move
d->canvasController->setScrollBarValue(scrollValue - scrollChange);
}
Maybe this code should only be executed when the scrollbar gets visible or is hidden?
o The canvas size is not always updated.
The reproduced:
- move an object to the right out of the page.
- unselect the object
- undo the change.
-> canvas should resize, but does not.
</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On May 15th, 2012, 8:59 a.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated May 15, 2012, 8:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KoPageApp applications Stage and Flow used to have extra space reserved around the page/slide so objects could be put there. However that made it really hard for the user to work with.
This patch changes that so there si no space around the page/slide. But.. instead you can drag objects outside the page/slide without any limit at all</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tested zooming in and out in Stage normal, notes, and sorter viewmodes, and in Flow.
I've tested that running presentations still work, however I've not tested presenterview.
I've tested moving shapes outside the page/slide in both Stage and Flow.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/KoPACanvas.cpp <span style="color: grey">(4a4748c)</span></li>
<li>libs/kopageapp/KoPAView.h <span style="color: grey">(01fbdf1)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(4d13dfa)</span></li>
<li>libs/kopageapp/KoPAViewModeNormal.cpp <span style="color: grey">(d5aa5f6)</span></li>
<li>libs/widgets/KoZoomController.h <span style="color: grey">(4f4c6a2)</span></li>
<li>libs/widgets/KoZoomController.cpp <span style="color: grey">(e10c5b4)</span></li>
<li>stage/part/KPrViewModeNotes.h <span style="color: grey">(b707770)</span></li>
<li>stage/part/KPrViewModeNotes.cpp <span style="color: grey">(c951ade)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104928/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>