<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104797/">http://git.reviewboard.kde.org/r/104797/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 7th, 2012, 8:50 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dag, good work, we're closer to the final. Here's my proposal for naming. This is huge change I know but you can rename the classes using KDevelop or Creator quite easily.
General concept: Calligra libs use static polymorphism for naming so let's keep common prefix when possible.
This is Frame-based ODT renderer, so the prefix can be KoOdtFrameReport.
I propose to put this renderer's files to libs/koreport/renderer/odtframe/
Below are the exact proposed renames:
libs/koreport/renderer/KoReportODTRenderer2.h
libs/koreport/renderer/KoReportODTRenderer2.cpp
KoOdtFrameReportRenderer
libs/koreport/renderer/odt/KoSimpleOdtCheckBox.h
libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp
KoOdtFrameReportCheckBox
libs/koreport/renderer/odt/KoSimpleOdtDocument.h
libs/koreport/renderer/odt/KoSimpleOdtDocument.cpp
KoOdtFrameReportDocument
libs/koreport/renderer/odt/KoSimpleOdtImage.h
libs/koreport/renderer/odt/KoSimpleOdtImage.cpp
KoOdtFrameReportImage
libs/koreport/renderer/odt/KoSimpleOdtLine.h
libs/koreport/renderer/odt/KoSimpleOdtLine.cpp
KoOdtFrameReportLine
libs/koreport/renderer/odt/KoSimpleOdtPicture.h
libs/koreport/renderer/odt/KoSimpleOdtPicture.cpp
KoOdtFrameReportPicture
libs/koreport/renderer/odt/KoSimpleOdtPrimitive.h
libs/koreport/renderer/odt/KoSimpleOdtPrimitive.cpp
KoOdtFrameReportTextBox
libs/koreport/renderer/odt/KoSimpleOdtTextBox.h
libs/koreport/renderer/odt/KoSimpleOdtTextBox.cpp
libs/koreport/renderer/odt/ReportODTRenderer.h
KoOdtFrameReportImage
PS: After this improvement we would be able to rename Adam's renderer classes to KoOdtTableReport*
and move them to libs/koreport/renderer/odttable.
</pre>
</blockquote>
<p>On May 9th, 2012, 6:59 a.m., <b>Dag Andersen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done</pre>
</blockquote>
<p>On May 9th, 2012, 8:30 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, can I see the updated patch?
I also have question about testing. In the light of our new code review rules, can we accept this new feature when testing was done with one app instead of two (i.e. without Kexi)?</pre>
</blockquote>
<p>On May 9th, 2012, 8:37 p.m., <b>Adam Pigg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess there is no impact on Kexi until we enable use of this output format?</pre>
</blockquote>
<p>On May 9th, 2012, 8:43 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adam, no there's no impact. But the reason of moving a feature to shared libs area is to actually... share it. So either we validate the design being reviewed here by adding use for Kexi too in this patch directly or we declare that after committing we add Kexi support sooner than later. This would enable convenient validation.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good point ;)
Atm I have very little time to work on calligra at all. The code is in a separate branch so maybe we shall let this rest until somebody get it tested with kexi and then take it from there.</pre>
<br />
<p>- Dag</p>
<br />
<p>On April 30th, 2012, 4:31 p.m., Dag Andersen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Jarosław Staniek and Adam Pigg.</div>
<div>By Dag Andersen.</div>
<p style="color: grey;"><i>Updated April 30, 2012, 4:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes is in branch: report_odt_danders
Move plans odt export into libs/koreport.
Retains the current odt export in koreport (as odttables) and
adds the new as odtframes.
Patch includes modifications to Plan to enable use of both formats.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with Plan, resulting files opened with Words.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/CMakeLists.txt <span style="color: grey">(d0737c9)</span></li>
<li>libs/koreport/renderer/KoReportODTRenderer2.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/KoReportODTRenderer2.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/KoReportRendererBase.cpp <span style="color: grey">(497177d)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtCheckBox.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtDocument.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtDocument.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtImage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtImage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtLine.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtLine.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtPicture.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtPicture.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtPrimitive.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtPrimitive.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtTextBox.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtTextBox.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/ReportODTRenderer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plan/libs/ui/CMakeLists.txt <span style="color: grey">(4948bd3)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtCheckBox.h <span style="color: grey">(94123e2)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtCheckBox.cpp <span style="color: grey">(9a94f5b)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtDocument.h <span style="color: grey">(65bbbee)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtDocument.cpp <span style="color: grey">(7d917ef)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtImage.h <span style="color: grey">(3c40922)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtImage.cpp <span style="color: grey">(1061664)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtLine.h <span style="color: grey">(6ea097b)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtLine.cpp <span style="color: grey">(2347117)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtPicture.h <span style="color: grey">(10c3b85)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtPicture.cpp <span style="color: grey">(e0df27f)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtPrimitive.h <span style="color: grey">(7cff1c7)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtPrimitive.cpp <span style="color: grey">(ddea498)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtTextBox.h <span style="color: grey">(428dff7)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtTextBox.cpp <span style="color: grey">(d775689)</span></li>
<li>plan/libs/ui/reports/odt/ReportODTRenderer.h <span style="color: grey">(3c9f149)</span></li>
<li>plan/libs/ui/reports/odt/ReportODTRenderer.cpp <span style="color: grey">(2c95ed2)</span></li>
<li>plan/libs/ui/reports/report.h <span style="color: grey">(8cef5be)</span></li>
<li>plan/libs/ui/reports/reportexportpanel.cpp <span style="color: grey">(973078d)</span></li>
<li>plan/libs/ui/reports/reportview.h <span style="color: grey">(265080a)</span></li>
<li>plan/libs/ui/reports/reportview.cpp <span style="color: grey">(dea21a6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104797/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>