<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104928/">http://git.reviewboard.kde.org/r/104928/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 13th, 2012, 7:14 p.m., <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104928/diff/1/?file=64127#file64127line124" style="color: black; font-weight: bold; text-decoration: underline;">libs/widgets/KoZoomController.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public slots:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">124</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QSizeF</span> <span class="n">documentSize</span><span class="p">()</span> <span class="k">const</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While 'document' may be what it's called in the zoom controller, I think it is confusing. Granted, the size of the document is not clearly defined in a page app, but I still think it makes more sense to call it workareaSize() or something. At least that's not possible to confuse with any size from KoDocument (if there is anything like that). In general, reusing names for different concapts is a reciepe for confusion.</pre>
</blockquote>
<p>On May 13th, 2012, 7:25 p.m., <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">...reusing names for different _concepts_ is a _recipe_ for confusion. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this has nothing to do with this review request. Boemann just uses the terms that are used in the used classes. As this is totally unrelated to the review request this should if handled done separately.</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On May 13th, 2012, 1:31 a.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated May 13, 2012, 1:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KoPageApp applications Stage and Flow used to have extra space reserved around the page/slide so objects could be put there. However that made it really hard for the user to work with.
This patch changes that so there si no space around the page/slide. But.. instead you can drag objects outside the page/slide without any limit at all</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tested zooming in and out in Stage normal, notes, and sorter viewmodes, and in Flow.
I've tested that running presentations still work, however I've not tested presenterview.
I've tested moving shapes outside the page/slide in both Stage and Flow.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/KoPACanvas.cpp <span style="color: grey">(4a4748c)</span></li>
<li>libs/kopageapp/KoPAView.h <span style="color: grey">(01fbdf1)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(4d13dfa)</span></li>
<li>libs/kopageapp/KoPAViewMode.cpp <span style="color: grey">(6981382)</span></li>
<li>libs/widgets/KoZoomController.h <span style="color: grey">(4f4c6a2)</span></li>
<li>libs/widgets/KoZoomController.cpp <span style="color: grey">(e10c5b4)</span></li>
<li>stage/part/KPrViewModeNotes.h <span style="color: grey">(b707770)</span></li>
<li>stage/part/KPrViewModeNotes.cpp <span style="color: grey">(c951ade)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104928/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>