<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104873/">http://git.reviewboard.kde.org/r/104873/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After fixing the two things I pointed out it is good to get in.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104873/diff/5/?file=64178#file64178line137" style="color: black; font-weight: bold; text-decoration: underline;">libs/flake/KoPathShape.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoPathShape::saveContourOdf(KoShapeSavingContext &context, const QSizeF &scaleFactor) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">137</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">currPoint</span> <span class="o">&&</span> <span class="o">!</span><span class="n">currPoint</span><span class="o">-></span><span class="n">activeControlPoint1</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think that should also check for activeControlPoint2</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104873/diff/5/?file=64182#file64182line77" style="color: black; font-weight: bold; text-decoration: underline;">libs/textlayout/KoTextLayoutObstruction.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QPainterPath KoTextLayoutObstruction::decoratedOutline(const KoShape *shape, qreal &borderHalfWidth) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">77</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoClipPath</span> <span class="o">*</span><span class="n">clipPath</span> <span class="o">=</span> <span class="n">shape</span><span class="o">-></span><span class="n">clipPath</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please move inside the if as ithe clipPath is not needed in the else case</pre>
</div>
<br />
<p>- Thorsten</p>
<br />
<p>On May 13th, 2012, 9:19 a.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated May 13, 2012, 9:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Load and save the contour-polygon and contour-path elements.
They are stored as KoClipPath in the engine. Previously the engine only
had support for loading and saving KoClipPath in svg
Load and save the style frame style attributes that turn contoured text run around
(wrapping) on and off. wrap-contour and wrap-contour-mode
Use this new technology to do tight run around (simple change only requesting what we already had)
This commit also adds a method to pictureshape to create a tightfitting outline path of the image.
It's tested and works, but is not used yet to create a KoClipPath out of it.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've created such contour clipping in LO
loaded and seen it work in Words, and saved it back to LO where it works (though we need to work around a bug in LO, workaround is there but not enabled in this diff)
For the unused method in the pictre shape I had hardwired it during development. I will put up a new review when I actually use the method so you may ignore it for now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoPathShape.h <span style="color: grey">(d6e7cf1)</span></li>
<li>libs/flake/KoPathShape.cpp <span style="color: grey">(fc59f87)</span></li>
<li>libs/flake/KoShape.h <span style="color: grey">(3b2ee21)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(40c2be2)</span></li>
<li>libs/flake/KoShape_p.h <span style="color: grey">(a8ef367)</span></li>
<li>libs/textlayout/KoTextLayoutObstruction.cpp <span style="color: grey">(9711578)</span></li>
<li>plugins/pictureshape/PictureShape.h <span style="color: grey">(54cc813)</span></li>
<li>plugins/pictureshape/PictureShape.cpp <span style="color: grey">(e4f58fe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104873/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>