<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104910/">http://git.reviewboard.kde.org/r/104910/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks nice enough to me, but I'll like another pair of eyes to look it through too</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104910/diff/1/?file=63933#file63933line26" style="color: black; font-weight: bold; text-decoration: underline;">words/part/Info.plist.template</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <string><span class="hl">K</span>WRD</string></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <string><span class="hl">C</span>WRD</string></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I assume you have checked there is no conflict with this</pre>
</div>
<br />
<p>- C.</p>
<br />
<p>On May 10th, 2012, 11:17 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated May 10, 2012, 11:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems there are some artifacts left-over from the BIG RENAME, i.e. the mimetypes "application/x-words" and "application/x-flow".
This patch fixes this by either changing to the new real native format of Words and Flow or removing the mimetype.
"KWDocument::extraNativeMimeTypes(...)" is removed because no longer needed. But left the method in the base class virtual for now.
Additionally it removes the files words/part/KWDLoader.* completely as they are not updated/used/compiled.
Occurences in generic_wrapper, xsltfilter and libexport are not touched, as they seem outdated anyway and I am posting another review request which removes them.
The occurence of x-flow in flowimageexport is also not touched, because it is currently not compiled, but I am trying to port it right now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>active/calligraactive.desktop <span style="color: grey">(cced14d)</span></li>
<li>libs/main/DESIGN <span style="color: grey">(36ccc9b)</span></li>
<li>libs/main/KoFilterManager_p.cpp <span style="color: grey">(645c18d)</span></li>
<li>libs/main/Mainpage.dox <span style="color: grey">(c1da98e)</span></li>
<li>libs/main/kodocinfopropspage.desktop <span style="color: grey">(8cbf874)</span></li>
<li>libs/main/tests/filterchain_test.cpp <span style="color: grey">(c7f6fd1)</span></li>
<li>servicetypes/calligrapart.desktop <span style="color: grey">(a64d512)</span></li>
<li>tools/quickprint/flow_konqi.desktop <span style="color: grey">(7cfd251)</span></li>
<li>tools/quickprint/words_konqi.desktop <span style="color: grey">(eb99e19)</span></li>
<li>tools/thumbnail/calligrathumbnail.desktop <span style="color: grey">(e41e52c)</span></li>
<li>words/part/Info.plist.template <span style="color: grey">(17259d4)</span></li>
<li>words/part/KWDLoader.h <span style="color: grey">(dfab5f0)</span></li>
<li>words/part/KWDLoader.cpp <span style="color: grey">(5f79418)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(f2d812a)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(65d027c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104910/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>