<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104797/">http://git.reviewboard.kde.org/r/104797/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 6th, 2012, 9:10 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104797/diff/1/?file=59659#file59659line64" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/renderer/KoReportRendererBase.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoReportRendererBase* KoReportRendererFactory::createInstance(const QString& key)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">key</span><span class="p">.</span><span class="n">toLower</span><span class="p">()</span> <span class="o">==</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">"odt"</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">64</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">key</span><span class="p">.</span><span class="n">toLower</span><span class="p">()</span> <span class="o">==</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">"odt<span class="hl">tables"</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="o"><span class="hl">||</span></span><span class="hl"> </span><span class="n"><span class="hl">key</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">toLower</span></span><span class="p"><span class="hl">()</span></span><span class="hl"> </span><span class="o"><span class="hl">==</span></span><span class="hl"> </span><span class="n"><span class="hl">QLatin1String</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">"odt</span>"</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since it's a new code, I propose to get the habit of using QString::compare(..., ..., Qt::CaseInsensitive)</pre>
</blockquote>
<p>On May 7th, 2012, 10:01 a.m., <b>Dag Andersen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a modification of an existing file and in a row of similar code, so I would rather keep this style in this patch and then modufy all instances in a separate patch</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 6th, 2012, 9:10 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104797/diff/1/?file=59661#file59661line60" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoSimpleOdtCheckBox::createStyle(KoGenStyles &coll)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">gs</span><span class="p">.</span><span class="n">addProperty</span><span class="p">(</span><span class="s">"fo:margin"</span><span class="p">,</span> <span class="s">"0.000000000000000pt"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is't 0.0pt enough?</pre>
</blockquote>
<p>On May 7th, 2012, 10:01 a.m., <b>Dag Andersen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure, but:
This is the way words and LO formats pt values (probably for a reason), so I would like keep it this way too.
(Same for the following similar cases)</pre>
</blockquote>
<p>On May 7th, 2012, 10:06 a.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">uhm we do gs.addPropertyPt("fo:margin", 0);
places where we do as you say would be maybe not bug but wrong (note the different method)</pre>
</blockquote>
<p>On May 7th, 2012, 10:25 a.m., <b>Dag Andersen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ahhh, so it just ends up in the xml file in the long format.
Ok, I'll use the gs.addPropertyPt() instead...
Done.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 6th, 2012, 9:10 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104797/diff/1/?file=59663#file59663line160" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/renderer/odt/KoSimpleOdtDocument.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KoSimpleOdtDocument::createContent(KoOdfWriteStore* store, KoGenStyles &coll)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">160</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kDebug</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Bad things happened"</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">how about using kWarning()? there are more such cases...</pre>
</blockquote>
<p>On May 7th, 2012, 10:01 a.m., <b>Dag Andersen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed the (useless) kDebug with Q_ASSERT.
(This situation should never happen...)
AFAICS the other case(s) is not in this patch.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I still suggest to use kWarnings everywhere. Q_ASSERT is for implementation error, so not for this case. API design suggest that calling function with any arguments should not cause to program failure.</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On April 30th, 2012, 4:31 p.m., Dag Andersen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Jarosław Staniek and Adam Pigg.</div>
<div>By Dag Andersen.</div>
<p style="color: grey;"><i>Updated April 30, 2012, 4:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes is in branch: report_odt_danders
Move plans odt export into libs/koreport.
Retains the current odt export in koreport (as odttables) and
adds the new as odtframes.
Patch includes modifications to Plan to enable use of both formats.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with Plan, resulting files opened with Words.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/CMakeLists.txt <span style="color: grey">(d0737c9)</span></li>
<li>libs/koreport/renderer/KoReportODTRenderer2.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/KoReportODTRenderer2.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/KoReportRendererBase.cpp <span style="color: grey">(497177d)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtCheckBox.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtDocument.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtDocument.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtImage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtImage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtLine.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtLine.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtPicture.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtPicture.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtPrimitive.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtPrimitive.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtTextBox.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/KoSimpleOdtTextBox.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/renderer/odt/ReportODTRenderer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plan/libs/ui/CMakeLists.txt <span style="color: grey">(4948bd3)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtCheckBox.h <span style="color: grey">(94123e2)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtCheckBox.cpp <span style="color: grey">(9a94f5b)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtDocument.h <span style="color: grey">(65bbbee)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtDocument.cpp <span style="color: grey">(7d917ef)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtImage.h <span style="color: grey">(3c40922)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtImage.cpp <span style="color: grey">(1061664)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtLine.h <span style="color: grey">(6ea097b)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtLine.cpp <span style="color: grey">(2347117)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtPicture.h <span style="color: grey">(10c3b85)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtPicture.cpp <span style="color: grey">(e0df27f)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtPrimitive.h <span style="color: grey">(7cff1c7)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtPrimitive.cpp <span style="color: grey">(ddea498)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtTextBox.h <span style="color: grey">(428dff7)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtTextBox.cpp <span style="color: grey">(d775689)</span></li>
<li>plan/libs/ui/reports/odt/ReportODTRenderer.h <span style="color: grey">(3c9f149)</span></li>
<li>plan/libs/ui/reports/odt/ReportODTRenderer.cpp <span style="color: grey">(2c95ed2)</span></li>
<li>plan/libs/ui/reports/report.h <span style="color: grey">(8cef5be)</span></li>
<li>plan/libs/ui/reports/reportexportpanel.cpp <span style="color: grey">(973078d)</span></li>
<li>plan/libs/ui/reports/reportview.h <span style="color: grey">(265080a)</span></li>
<li>plan/libs/ui/reports/reportview.cpp <span style="color: grey">(dea21a6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104797/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>