<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104738/">http://git.reviewboard.kde.org/r/104738/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On April 26th, 2012, 5:14 p.m., Marijn Kruisselbrink wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Marijn Kruisselbrink.</div>
<p style="color: grey;"><i>Updated April 26, 2012, 5:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Somehow we ended up with two copies of the KoItemToolTip class, one in kowidgets and one in komain. (and worse, some bug fixes were only applied to one of the two copies). This fixes that by only having one copy of the class, in the kowidgets library. I copied the komain version there since that version had some bug fixes that the kowidgets version didn't get.
The only potential downside to this I can see is that now the class needs to be exported (since the only users of it are in kowidgets and komain, the class wasn't exported before and instead somebody decided to have two copies instead).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/CMakeLists.txt <span style="color: grey">(f4074ea)</span></li>
<li>libs/main/KoItemToolTip.h <span style="color: grey">(4e35e1e)</span></li>
<li>libs/main/KoItemToolTip.cpp <span style="color: grey">(72b3801)</span></li>
<li>libs/widgets/KoItemToolTip.h <span style="color: grey">(91dd510)</span></li>
<li>libs/widgets/KoItemToolTip.cpp <span style="color: grey">(beffbcb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104738/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>