<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104701/">http://git.reviewboard.kde.org/r/104701/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is a mismatch between reading and writing of the config entry "unit" for a document:
all code writes that entry to "view-settings" group:
KarbonPart::saveOasisSettings(...)
KoPADocument::saveOdfSettings(...)
DocBase::saveOdfHelper(...)
KWOdfWriter::saveOdfSettings(...)
and most read it from there:
KarbonPart::loadOasisSettings(...)
KoPADocument::loadOdfSettings(...)
DocBase::loadOdfSettings(...)
But KWOdfLoader::loadSettings(...) only read from old (before odf 1.2?) "ooo:view-settings", thus the bug.
While the attached patch fixes the bug, I wonder if KarbonPart, KoPADocument and DocBase should also try "ooo:view-settings" for backward-compability?
Or should the patch be to just change "ooo:view-settings" to "view-settings", ignoring any backward compatibility?
I could not find any documentation on the setting properties for ODF, so need some with more clue to comment this.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created a new document with Calligra Words, changed the unit to Pica, saved it, closed Words. Restarted Words, load that document and see the settings updated to Pica (already with the tuneKoUnit branch merged to master locally)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=298510">298510</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>words/part/KWOdfLoader.cpp <span style="color: grey">(c4cbcee)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104701/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>