<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104666/">http://git.reviewboard.kde.org/r/104666/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It looks good to me. Krita doesn't need a tab chooser. (Well, technically, it could be useful if the active shape on a vector layer is a text shape, but I'm not sure that's something our users really care about.)</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On April 19th, 2012, 1:58 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated April 19, 2012, 1:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently in all programs (besides Words) the tab chooser is wrongly displayed somewhere on the horizontal ruler. And also if not needed, i.e. tabs are no property of the shape.
Attached patch fixes that:
* it puts the tab chooser in the corner for Stage and Karbon (so not for Krita, because less text oriented)
* it only creates the tab chooser on demand, not always (so it does not appear for Krita, like now)
* it only shows the tabs chooser if tabs are also shown in the ruler
(not sure that there should be no tab chooser for Krita)
Candidate for 2.4 backport?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Started Krita, Karbon, Stage, Words and activated text shapes, had rulers shown and not shown.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>karbon/ui/KarbonView.cpp <span style="color: grey">(2b9a907)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(fc28628)</span></li>
<li>libs/koreport/wrtembed/KoReportDesigner.cpp <span style="color: grey">(68a61f9)</span></li>
<li>libs/main/KoRuler.cpp <span style="color: grey">(4272b9b)</span></li>
<li>libs/main/KoRulerController.cpp <span style="color: grey">(39a2e3b)</span></li>
<li>libs/main/KoRuler_p.h <span style="color: grey">(bfeac46)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104666/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>