<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104553/">http://git.reviewboard.kde.org/r/104553/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Thorsten Zachmann.</div>
<div>By Friedrich W. H. Kossebau.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The markers in the KoMarkerSelector have been somehow off. Also the line width has been different from the one in the line style selector.
This patch changes this by having the marker model only deliver the marker, not a full line shape with the marker set and fixed end points for the line.
The marker delegate and the marker selector now draw the line with the marker based on the available rect, similar to how the line selector does it.
Some things still left to do/think about:
* some margins to the left and right side of the line?
* find a way to calculate the max height/width of the marker, to be used for the sizeHint/minSize per item
* redo the whole stroke config widget and e.g. place marker selectors to the left and the right of the style selector
But this patch already is a first improvement on its own IMHO. Agreed?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/widgets/KoMarkerItemDelegate.h <span style="color: grey">(c1e715a)</span></li>
<li>libs/widgets/KoMarkerItemDelegate.cpp <span style="color: grey">(f628479)</span></li>
<li>libs/widgets/KoMarkerModel.h <span style="color: grey">(3e44db0)</span></li>
<li>libs/widgets/KoMarkerModel.cpp <span style="color: grey">(f21848f)</span></li>
<li>libs/widgets/KoMarkerSelector.h <span style="color: grey">(3d7b9db)</span></li>
<li>libs/widgets/KoMarkerSelector.cpp <span style="color: grey">(55cb302)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104553/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104553/s/521/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/12/StrokeMarker-Before_400x100.png" style="border: 1px black solid;" alt="Before" /></a>
<a href="http://git.reviewboard.kde.org/r/104553/s/522/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/12/StrokeMarker-After_400x100.png" style="border: 1px black solid;" alt="After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>