<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104483/">http://git.reviewboard.kde.org/r/104483/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 7th, 2012, 6:35 a.m., <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I didn't see anybody else answer this so I'll do it. Yes, the 'after' looks much better.
Regarding 2.4, I would have liked it, but the tag of 2.4.0 is done now so that's too late. I'm not sure if we want to make a change like this to appear in 2.4.x (x>0) but if it came down to a vote I would vote 'yes'.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for answering :) Will commit to master now.
Regarding 2.4 I think that after the initial release such optimizations should better only appear in the next version. At least I hope for some release-often-and-early process of Calligra now after the initial release, so the time it takes to get also these optimizations into released products is only a few months. So IMHO the effort needed to backport and review and test would simply better be spent for new improvements in master. And as user the more new things are in a new release, the more interested and excited I am about the new release. Would you turn your 'yes' to a 'no' based on this reasoning as well? :)</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On April 4th, 2012, 2:50 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated April 4, 2012, 2:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using toggable buttons with icons inside instead of checkboxes with icon next to it IMHO brings
* less visual clutter
* consistency with other icon-only state controls (e.g. text style or connection point)
See attached screenshots, with pointer tool dialog as example.
(missing icon is "snap-boundingbox", not part of my OpenSuse oxygen-icon-theme 4.8.2-138.1 package, is that in Oxygen at all, is also listed at http://community.kde.org/Calligra/Icons as missing)
Want in 2.4 as well?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/SnapGuideConfigWidget.h <span style="color: grey">(043fdb4)</span></li>
<li>libs/flake/SnapGuideConfigWidget.cpp <span style="color: grey">(8784f3c)</span></li>
<li>libs/flake/SnapGuideConfigWidget.ui <span style="color: grey">(487105e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104483/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104483/s/504/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/04/SnapOptionsWithCheckboxes_400x100.png" style="border: 1px black solid;" alt="Before" /></a>
<a href="http://git.reviewboard.kde.org/r/104483/s/505/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/04/SnapOptionsWithToolbuttons_400x100.png" style="border: 1px black solid;" alt="After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>