<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104487/">http://git.reviewboard.kde.org/r/104487/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One thing I'd really like to have before this goes in is unit tests. Currently (almost?) every function has several unit tests to test for correctness, so I don't really want new functions that get added to not have at least some basic unit tests.</pre>
<br />
<p>- Marijn</p>
<br />
<p>On April 5th, 2012, 12:56 a.m., Nityam Vakil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Nityam Vakil.</div>
<p style="color: grey;"><i>Updated April 5, 2012, 12:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To fully support all of the defined heighest level 4 formulas, I added support for formulas averageif, averageifs, sumifs, countifs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tested above formulas with some test data attached here. And it seems to be working fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sheets/ValueCalc.h <span style="color: grey">(d0018c2)</span></li>
<li>sheets/ValueCalc.cpp <span style="color: grey">(7e6f3a3)</span></li>
<li>sheets/functions/math.cpp <span style="color: grey">(d57ce94)</span></li>
<li>sheets/functions/statistical.cpp <span style="color: grey">(020b03e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104487/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>