<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104426/">http://git.reviewboard.kde.org/r/104426/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e70fb1460b30d856729d27dbc7091fd5e3d3c00b by Friedrich W. H. Kossebau to branch calligra/2.4.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 27th, 2012, 12:20 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated March 27, 2012, 12:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In Stage, Flow, Sheets it is not possible to make the toolbox that small that there is only a single column of buttons.
In Krita and Karbon it is possible.
In Stage, Flow, Sheets this results in a lot of unused screen real estate on the (default) right side.
Reason is that the KoDockWidgetTitleBar calculates the minimal width by including the full width of the title.
Krita and Karbon seem to work around that by setting the title to " "... tss ;)
But this workaround results in an empty title in the dock widgets title context menu (see by RMB on dockwidget title).
Attached patch changes this, by:
* making the minimal width of the KoDockWidgetTitleBar optionally depending on the text width
* setting the title of the toolbox dockwidget always to "Tools"
* showing a tooltip with the title name for the toolbox dockwidget
Commits which make this patch have the titles:
Changed: no need to set KoDockWidgetTitleBar::ignoreTextSize to false in KoToolBoxDocker, is false by default
Removed: unused methods KoDockWidgetTitleBar::setTextVisible/setIgnoreTextSize
Changed: no need to explicitely set toolbox title to "Tools", is default name
Added: TextVisibilityMode for KoDockWidgetTitleBar
Changes: align toolbox behaviour for all Calligra programs
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Played around with the toolbox in Stage, Flow, Sheets, Krita and Karbon, by resizing it, moving to other places and using tools.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>braindump/src/View.cpp <span style="color: grey">(baed830)</span></li>
<li>karbon/ui/KarbonView.cpp <span style="color: grey">(c02e954)</span></li>
<li>krita/ui/kis_view2.cpp <span style="color: grey">(e357284)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(ade6916)</span></li>
<li>libs/main/KoToolBoxDocker.cpp <span style="color: grey">(e6e3dc6)</span></li>
<li>libs/main/KoToolBoxDocker_p.h <span style="color: grey">(3cfc370)</span></li>
<li>libs/main/KoToolBoxFactory.h <span style="color: grey">(5567349)</span></li>
<li>libs/main/KoToolBoxFactory.cpp <span style="color: grey">(b3854f6)</span></li>
<li>libs/widgets/KoDockWidgetTitleBar.h <span style="color: grey">(c018e9a)</span></li>
<li>libs/widgets/KoDockWidgetTitleBar.cpp <span style="color: grey">(fe62390)</span></li>
<li>sheets/part/View.cpp <span style="color: grey">(5bb6acd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104426/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>