<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104432/">http://git.reviewboard.kde.org/r/104432/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great -- it does solve the bug! I wouldn't worry for now about the small issues remaining. When closing, please close bug 294601 as well.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On March 28th, 2012, 1:24 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated March 28, 2012, 1:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The algorithm for layouting of the toolbox seems to have a few issues:
* last button with multiple sections on row was cut off at end (spacing ignored)
* separators could appear on the top side of the toolbox
* and there is the linked bug
The attached patch is a small cleanup of the code which fixes these issues for me. Though I am not sure why it fixes the bug actually, might have been due to the too large rects assigned to the section widgets.
Still, there is an issue left:
currently it is supported to have a small section to be appended in the last row of a multi-row section. But this conflicts with that there is normally some spacing between the rows of different section. So e.g. the separator between the rows is painted on the bottom of the buttons of the row before. This is both with this patch and master. What to do about that? Not allow appending to multi-row sections? Have spacing also between rows of multi-row section? Do not do row separators between sections?</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=294601">294601</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/KoToolBox.cpp <span style="color: grey">(eb8c17f)</span></li>
<li>libs/main/KoToolBoxLayout_p.h <span style="color: grey">(fcfac47)</span></li>
<li>libs/main/KoToolBox_p.h <span style="color: grey">(628aacc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104432/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>