<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104421/">http://git.reviewboard.kde.org/r/104421/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just a few remarks in addition to your own remark</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104421/diff/1/?file=54862#file54862line24" style="color: black; font-weight: bold; text-decoration: underline;">libs/flake/KoFlake.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "Ko<span class="hl">LineBorder</span>.h"</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp"><span class="hl">//</span>#include "Ko<span class="hl">ShapeStroke</span>.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hmmm is this right?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104421/diff/1/?file=54865#file54865line29" style="color: black; font-weight: bold; text-decoration: underline;">libs/flake/KoResourceManager_p.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "Ko<span class="hl">LineBorder</span>.h"</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1"><span class="hl">//</span>#include "Ko<span class="hl">ShapeStroke</span>.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">and here too</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104421/diff/1/?file=54873#file54873line80" style="color: black; font-weight: bold; text-decoration: underline;">libs/flake/tests/TestShapeGroupCommand.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void TestShapeGroupCommand::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">strokeGroup</span><span class="o">-></span><span class="n">setStroke</span><span class="p">(</span> <span class="k">new</span> <span class="n">Ko<span class="hl">LineBorder</span></span><span class="p">(</span> <span class="mf">2.0f</span> <span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">strokeGroup</span><span class="o">-></span><span class="n">setStroke</span><span class="p">(</span> <span class="k">new</span> <span class="n">Ko<span class="hl">ShapeStroke</span></span><span class="p">(</span> <span class="mf">2.0f</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">strokeGroup</span><span class="o">-></span><span class="n">setShadow</span><span class="p">(</span> <span class="k">new</span> <span class="n">KoShapeShadow</span><span class="p">()</span> <span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">strokeGroup</span><span class="o">-></span><span class="n">setShadow</span><span class="p">(</span> <span class="k">new</span> <span class="n">KoShapeShadow</span><span class="p">()</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i would have taken the oppotunity to follow the hacking style here..</pre>
</div>
<br />
<p>- C.</p>
<br />
<p>On March 27th, 2012, 12:53 a.m., Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated March 27, 2012, 12:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the continuation of my last two patches. It renames the KoLineBorder class in libs/flake to KoShapeStroke. I would have preferred KoStroke since it doesn't have anything to do with shapes per se, but a) it's in libs/flake, not libs/odf and b) the other similar classes had KoShape... names like KoShapeBackground and KoShapeShadow.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested with most ways I could change strokes and I couldn't find any new bugs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/karbon/wmf/WmfExport.cpp <span style="color: grey">(47ff598)</span></li>
<li>karbon/common/KarbonOutlinePaintingStrategy.h <span style="color: grey">(f29d799)</span></li>
<li>karbon/common/KarbonOutlinePaintingStrategy.cpp <span style="color: grey">(ef338df)</span></li>
<li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp <span style="color: grey">(c861e0d)</span></li>
<li>karbon/plugins/tools/KarbonGradientEditStrategy.h <span style="color: grey">(a4d5e99)</span></li>
<li>karbon/plugins/tools/KarbonGradientEditStrategy.cpp <span style="color: grey">(36725af)</span></li>
<li>karbon/plugins/tools/KarbonGradientTool.cpp <span style="color: grey">(a4d6ebb)</span></li>
<li>karbon/plugins/tools/KarbonPencilTool.h <span style="color: grey">(0f26da3)</span></li>
<li>karbon/plugins/tools/KarbonPencilTool.cpp <span style="color: grey">(8180faa)</span></li>
<li>karbon/ui/KarbonView.cpp <span style="color: grey">(c02e954)</span></li>
<li>karbon/ui/widgets/KarbonPaletteBarWidget.cpp <span style="color: grey">(15a4696)</span></li>
<li>karbon/ui/widgets/KarbonSmallStylePreview.cpp <span style="color: grey">(f03d68d)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(fc515db)</span></li>
<li>libs/flake/KoCanvasResourceManager.h <span style="color: grey">(163ba6f)</span></li>
<li>libs/flake/KoCanvasResourceManager.cpp <span style="color: grey">(af07357)</span></li>
<li>libs/flake/KoConnectionShapeFactory.cpp <span style="color: grey">(b0b4f0b)</span></li>
<li>libs/flake/KoDocumentResourceManager.h <span style="color: grey">(4396aea)</span></li>
<li>libs/flake/KoFlake.cpp <span style="color: grey">(81dc117)</span></li>
<li>libs/flake/KoPathShape.cpp <span style="color: grey">(5fa931f)</span></li>
<li>libs/flake/KoPathShapeFactory.cpp <span style="color: grey">(663dd5c)</span></li>
<li>libs/flake/KoResourceManager_p.cpp <span style="color: grey">(2967b6f)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(511b54d)</span></li>
<li>libs/flake/KoShapeStroke.h <span style="color: grey">(27da450)</span></li>
<li>libs/flake/KoShapeStroke.cpp <span style="color: grey">(04d5a7b)</span></li>
<li>libs/flake/svg/SvgGraphicContext.h <span style="color: grey">(9f08241)</span></li>
<li>libs/flake/svg/SvgParser.cpp <span style="color: grey">(f0d4c03)</span></li>
<li>libs/flake/svg/SvgStyleWriter.cpp <span style="color: grey">(cf4fb71)</span></li>
<li>libs/flake/tests/TestShapeAt.cpp <span style="color: grey">(d07eb1c)</span></li>
<li>libs/flake/tests/TestShapeGroupCommand.cpp <span style="color: grey">(c5bf2a2)</span></li>
<li>libs/flake/tests/TestShapeStrokeCommand.cpp <span style="color: grey">(d300180)</span></li>
<li>libs/flake/tools/KoCreatePathTool.h <span style="color: grey">(770f3ec)</span></li>
<li>libs/flake/tools/KoCreatePathTool.cpp <span style="color: grey">(4d3142b)</span></li>
<li>libs/kopageapp/KoPADocument.cpp <span style="color: grey">(afcde61)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.h <span style="color: grey">(e80c434)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.cpp <span style="color: grey">(2fa69a9)</span></li>
<li>plugins/artistictextshape/ArtisticTextTool.cpp <span style="color: grey">(492ba6f)</span></li>
<li>plugins/chartshape/ChartShape.cpp <span style="color: grey">(ddc5eab)</span></li>
<li>plugins/chartshape/Legend.cpp <span style="color: grey">(561eeca)</span></li>
<li>plugins/commentshape/CommentShape.cpp <span style="color: grey">(a1adca87)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionTool.cpp <span style="color: grey">(58ce99f)</span></li>
<li>plugins/dockers/strokedocker/StrokeDocker.cpp <span style="color: grey">(fc4d8c2)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.cpp <span style="color: grey">(e11a2bf)</span></li>
<li>plugins/pathshapes/ellipse/EllipseShapeFactory.cpp <span style="color: grey">(5a20373)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp <span style="color: grey">(d2dcfe4)</span></li>
<li>plugins/pathshapes/rectangle/RectangleShapeFactory.cpp <span style="color: grey">(d7b7427)</span></li>
<li>plugins/pathshapes/spiral/SpiralShapeFactory.cpp <span style="color: grey">(c304999)</span></li>
<li>plugins/pathshapes/star/StarShapeFactory.cpp <span style="color: grey">(aa91bd3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104421/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>