<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104405/">http://git.reviewboard.kde.org/r/104405/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please fix the noted things before committing</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104405/diff/1/?file=54583#file54583line1042" style="color: black; font-weight: bold; text-decoration: underline;">karbon/ui/KarbonView.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KarbonView::initActions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1042</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KAction</span> <span class="o">*</span><span class="n">actionDistributeLeft</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KAction</span><span class="p">(</span><span class="n">KIcon</span><span class="p">(</span><span class="s">"distribute-horizontal-left"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Distribute Left <span class="hl">Border</span>s"</span><span class="p">),</span> <span class="k">this</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1042</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KAction</span> <span class="o">*</span><span class="n">actionDistributeLeft</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KAction</span><span class="p">(</span><span class="n">KIcon</span><span class="p">(</span><span class="s">"distribute-horizontal-left"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Distribute Left <span class="hl">Stroke</span>s"</span><span class="p">),</span> <span class="k">this</span><span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1043</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">actionCollection</span><span class="p">()</span><span class="o">-></span><span class="n">addAction</span><span class="p">(</span><span class="s">"object_distribute_horizontal_left"</span><span class="p">,</span> <span class="n">actionDistributeLeft</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1043</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">actionCollection</span><span class="p">()</span><span class="o">-></span><span class="n">addAction</span><span class="p">(</span><span class="s">"object_distribute_horizontal_left"</span><span class="p">,</span> <span class="n">actionDistributeLeft</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1044</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">actionDistributeLeft</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">triggered</span><span class="p">()),</span> <span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">selectionDistributeHorizontalLeft</span><span class="p">()));</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1044</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">actionDistributeLeft</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">triggered</span><span class="p">()),</span> <span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">selectionDistributeHorizontalLeft</span><span class="p">()));</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1045</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1045</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1046</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KAction</span> <span class="o">*</span><span class="n">actionDistributeRight</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KAction</span><span class="p">(</span><span class="n">KIcon</span><span class="p">(</span><span class="s">"distribute-horizontal-right"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Distribute Right Borders"</span><span class="p">),</span> <span class="k">this</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1046</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KAction</span> <span class="o">*</span><span class="n">actionDistributeRight</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KAction</span><span class="p">(</span><span class="n">KIcon</span><span class="p">(</span><span class="s">"distribute-horizontal-right"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Distribute Right Borders"</span><span class="p">),</span> <span class="k">this</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think strokes does not make much sense here. Also all texts should use the same terms.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104405/diff/1/?file=54622#file54622line28" style="color: black; font-weight: bold; text-decoration: underline;">libs/kopageapp/KoPADocumentModel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <KoShapeBorderModel.h></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp"><span class="hl">//</span>#include <KoShapeBorderModel.h></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If those are not needed please remove.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104405/diff/1/?file=54623#file54623line34" style="color: black; font-weight: bold; text-decoration: underline;">libs/kopageapp/KoPADocumentStructureDocker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">34</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <KoShape<span class="hl">Border</span>Model.h></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">34</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp"><span class="hl">//</span>#include <KoShape<span class="hl">Stroke</span>Model.h></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If those are not needed please remove</pre>
</div>
<br />
<p>- Thorsten</p>
<br />
<p>On March 25th, 2012, 5:53 p.m., Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated March 25, 2012, 5:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch changes KoShapeBorderModel into KoShapeStrokeModel and also a couple of related classes.
There are 2 reasons for this change:
1. It increases the name describes what it actually is for. There are many places in the code that looks like:
KoShapeBorderModel *stroke = ...
so naming it "...Stroke..." is both closer to the odf tags and also to the rest of the code.
2. It reduces the confusion between KoShapeBorderModel and KoBorder which don't have anything to do with each other.
If this patch is accepted, I want to continue with the KoLineBorder class but I don't understand that one 100% yet so I want to wait until I do. It's also possible to follow up with KoBackground -> KoFill, but that's not nearly as confusing so I don't think it's strictly necessary.
As far as I can remember this topic was up for discussion about a year ago and was met with general approval but that could also be wishful thinking.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested around as much as I could but i couldn't find any differences in behaviour from before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/CMakeLists.txt <span style="color: grey">(8db919b)</span></li>
<li>karbon/ui/widgets/KarbonSmallStylePreview.cpp <span style="color: grey">(d62dfaf)</span></li>
<li>karbon/ui/widgets/KarbonPaletteBarWidget.cpp <span style="color: grey">(b92813f)</span></li>
<li>karbon/ui/dockers/KarbonLayerDocker.cpp <span style="color: grey">(2b6eb67)</span></li>
<li>karbon/ui/dockers/KarbonLayerModel.cpp <span style="color: grey">(78d96b1)</span></li>
<li>karbon/ui/KarbonView.cpp <span style="color: grey">(a5b5394)</span></li>
<li>karbon/plugins/tools/KarbonPencilTool.cpp <span style="color: grey">(32f1723)</span></li>
<li>karbon/plugins/tools/KarbonPencilTool.h <span style="color: grey">(853e325)</span></li>
<li>karbon/plugins/tools/KarbonGradientTool.cpp <span style="color: grey">(83e1cc5)</span></li>
<li>flow/plugins/dockers/stencilboxdocker/StencilBoxDocker.cpp <span style="color: grey">(a2c4818)</span></li>
<li>karbon/common/commands/KarbonBooleanCommand.cpp <span style="color: grey">(baab3f6)</span></li>
<li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphicShape.cpp <span style="color: grey">(454faf4)</span></li>
<li>karbon/plugins/tools/KarbonGradientEditStrategy.cpp <span style="color: grey">(48b313a)</span></li>
<li>filters/karbon/wmf/WmfExport.h <span style="color: grey">(b534c58)</span></li>
<li>filters/karbon/wmf/WmfExport.cpp <span style="color: grey">(990b85b)</span></li>
<li>libs/flake/KoCanvasResourceManager.h <span style="color: grey">(fdb1bdb)</span></li>
<li>libs/flake/KoCanvasResourceManager.cpp <span style="color: grey">(4b5def5)</span></li>
<li>libs/flake/KoConnectionShapeFactory.cpp <span style="color: grey">(5eab35e)</span></li>
<li>libs/flake/KoFlake.h <span style="color: grey">(10cc38a)</span></li>
<li>libs/flake/KoInsets.h <span style="color: grey">(9188530)</span></li>
<li>libs/flake/KoLineBorder.h <span style="color: grey">(7f7d088)</span></li>
<li>libs/flake/KoLineBorder.cpp <span style="color: grey">(f99da3d)</span></li>
<li>libs/flake/KoLineBorderFactory.h <span style="color: grey">(f961e88)</span></li>
<li>libs/flake/KoLineBorderFactory.cpp <span style="color: grey">(a9fe118)</span></li>
<li>libs/flake/KoPathShape.cpp <span style="color: grey">(2e1bdad)</span></li>
<li>libs/flake/KoPathShapeFactory.cpp <span style="color: grey">(b6f5b4d)</span></li>
<li>libs/flake/KoShape.h <span style="color: grey">(8dd981f)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(5ae13c9)</span></li>
<li>libs/flake/KoShapeBorderFactoryBase.h <span style="color: grey">(11ff35f)</span></li>
<li>libs/flake/KoShapeContainer.cpp <span style="color: grey">(ef26d97)</span></li>
<li>libs/flake/KoShapeGroup.cpp <span style="color: grey">(600d039)</span></li>
<li>libs/flake/KoShapeManager.cpp <span style="color: grey">(660e01c)</span></li>
<li>libs/flake/KoShapePainter.cpp <span style="color: grey">(09e2e1c)</span></li>
<li>libs/flake/KoShapeShadow.cpp <span style="color: grey">(75e5538)</span></li>
<li>libs/flake/KoShapeStrokeModel.h <span style="color: grey">(40b50e1)</span></li>
<li>libs/flake/KoShapeStrokeModel.cpp <span style="color: grey">(1041007)</span></li>
<li>libs/flake/KoShape_p.h <span style="color: grey">(aafa5d7)</span></li>
<li>libs/flake/commands/KoPathCombineCommand.cpp <span style="color: grey">(b752fcf)</span></li>
<li>libs/flake/commands/KoShapeStrokeCommand.h <span style="color: grey">(989749a)</span></li>
<li>libs/flake/commands/KoShapeStrokeCommand.cpp <span style="color: grey">(960aede)</span></li>
<li>libs/flake/svg/SvgParser.cpp <span style="color: grey">(0c74f5f)</span></li>
<li>libs/flake/svg/SvgStyleWriter.cpp <span style="color: grey">(e47f78f)</span></li>
<li>libs/flake/tests/CMakeLists.txt <span style="color: grey">(e4a4996)</span></li>
<li>libs/flake/tests/TestShapeAt.cpp <span style="color: grey">(8b6c6b1)</span></li>
<li>libs/flake/tests/TestShapeGroupCommand.cpp <span style="color: grey">(3be99b5)</span></li>
<li>libs/flake/tests/TestShapeStrokeCommand.h <span style="color: grey">(142471b)</span></li>
<li>libs/flake/tests/TestShapeStrokeCommand.cpp <span style="color: grey">(898e2ff)</span></li>
<li>libs/flake/tools/KoCreatePathTool.cpp <span style="color: grey">(151a4cf)</span></li>
<li>libs/kopageapp/KoPADocumentModel.cpp <span style="color: grey">(83cf3f1)</span></li>
<li>libs/kopageapp/KoPADocumentStructureDocker.cpp <span style="color: grey">(145d431)</span></li>
<li>libs/textlayout/KoTextLayoutObstruction.cpp <span style="color: grey">(e75970a)</span></li>
<li>plugins/artistictextshape/ArtisticTextTool.cpp <span style="color: grey">(8a97623)</span></li>
<li>plugins/chartshape/ChartShape.cpp <span style="color: grey">(d0fc3f0)</span></li>
<li>plugins/chartshape/Legend.cpp <span style="color: grey">(d6c0774)</span></li>
<li>plugins/commentshape/CommentShape.cpp <span style="color: grey">(c12b5d9)</span></li>
<li>plugins/dockers/strokedocker/StrokeDocker.h <span style="color: grey">(835f1e6)</span></li>
<li>plugins/dockers/strokedocker/StrokeDocker.cpp <span style="color: grey">(0d0f67b)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.h <span style="color: grey">(90a8c06)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.cpp <span style="color: grey">(4bc3e1e)</span></li>
<li>plugins/dockers/styledocker/StylePreview.h <span style="color: grey">(cf62aeb)</span></li>
<li>plugins/dockers/styledocker/StylePreview.cpp <span style="color: grey">(bdbff05)</span></li>
<li>plugins/pathshapes/ellipse/EllipseShapeFactory.cpp <span style="color: grey">(ebeb220)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathParameter.cpp <span style="color: grey">(5dde229)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp <span style="color: grey">(3898cda)</span></li>
<li>plugins/pathshapes/rectangle/RectangleShapeFactory.cpp <span style="color: grey">(b4e5ec8)</span></li>
<li>plugins/pathshapes/spiral/SpiralShapeFactory.cpp <span style="color: grey">(1080e20)</span></li>
<li>plugins/pathshapes/star/StarShapeFactory.cpp <span style="color: grey">(f2ccfca)</span></li>
<li>plugins/treeshape/TreeShape.cpp <span style="color: grey">(0589fa0)</span></li>
<li>words/part/frames/KWCopyShape.cpp <span style="color: grey">(8516de4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104405/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>