<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104370/">http://git.reviewboard.kde.org/r/104370/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 23rd, 2012, 3:25 a.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like the changes very much. great work.
ok to backport too</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, merged my commits to master now. Will backport next, should be straight-forward...</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On March 22nd, 2012, 11:42 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, C. Boemann and Dag Andersen.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated March 22, 2012, 11:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Small improvements (?) to things which jumped into my eyes a few times meanwhile.
* Changed: printing option widgets need to have outer margins set, due to being set to a tab page
* Changed: no need to set margins of KoPageLayoutWidget object to 0, is by default
* Changed: improve layout of KWDocumentColumns by using a QFormLayout
* Changed: make labels of KoPageLayoutWidget right-aligned, improve resize behaviour
Not sure if KoPageLayoutWidget should be resizable/enlargable at all, but it's consistent to other UIs,
so I have implemented some nicer enlarging behaviour there.
Okay to backport all to 2.4?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used all the UIs touched and resized them a few times.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(627d763)</span></li>
<li>libs/widgets/KoPageLayoutDialog.cpp <span style="color: grey">(7eaeb6a)</span></li>
<li>libs/widgets/KoPageLayoutWidget.ui <span style="color: grey">(b36e080)</span></li>
<li>plan/libs/ui/kptganttprintingoptions.ui <span style="color: grey">(2d9d85b)</span></li>
<li>plan/libs/ui/kptviewbase.cpp <span style="color: grey">(90bbad5)</span></li>
<li>words/part/dialogs/KWDocumentColumns.ui <span style="color: grey">(56e58ca)</span></li>
<li>words/part/dialogs/KWStartupWidget.cpp <span style="color: grey">(a0a43ac)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104370/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>