<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
On 03/19/2012 11:21 AM, Matus Uzak wrote:
<blockquote
cite="mid:CAPdReTKUmE_+sbs7XgNeueMHhE8wO50WbWAtu8EPfEFFbiTGNA@mail.gmail.com"
type="cite">
<meta http-equiv="Context-Type" content="text/html;
charset=ISO-8859-1">
Hi,<br>
<br>
I did not catch the irc conversation. The backslash in "\%" seems
to be ignored internally. I don't think it's an undocumented
escape sequence understood by QString, so I would remove it.<br>
Any objections from sebsauer and LukasT who were using those?<br>
</blockquote>
<br>
The code that uses it is not from me but from Bjoern (commit
648de6ad). Don't know why it was added...<br>
That sayed: no objections :)<br>
<br>
<blockquote
cite="mid:CAPdReTKUmE_+sbs7XgNeueMHhE8wO50WbWAtu8EPfEFFbiTGNA@mail.gmail.com"
type="cite"><br>
-matus<br>
<br>
<div>On Sun, Mar 18, 2012 at 4:52 AM, Andrius da Costa Ribas <span><<a
moz-do-not-send="true" href="mailto:andriusmao@gmail.com">andriusmao@gmail.com</a>></span>
wrote:<br>
<blockquote>Please find attached the patch for 2.4 branch
(Either reviewboard does not accept patches for non-master or
I don't know how to).<br>
<br>
<div>2012/3/17 Andrius da Costa Ribas <span><<a
moz-do-not-send="true"
href="mailto:andriusmao@gmail.com">andriusmao@gmail.com</a>></span><br>
<blockquote>Hello,
<div><br>
</div>
<div>As discussed on IRC, some sources contains "\%"
invalid escape sequence:</div>
<div>
<br>
</div>
<div>
<div>filters/libmso/ODrawToOdf.cpp(625):
style.addAttribute("svg:x1", QString("%1\%").arg(x1));</div>
<div>filters/libmso/ODrawToOdf.cpp(626):
style.addAttribute("svg:y1", QString("%1\%").arg(y1));</div>
<div>filters/libmso/ODrawToOdf.cpp(627):
style.addAttribute("svg:x2", QString("%1\%").arg(x2));</div>
<div>filters/libmso/ODrawToOdf.cpp(628):
style.addAttribute("svg:y2", QString("%1\%").arg(y2));</div>
<div>filters/libmso/ODrawToOdf.cpp(680):
style.addAttribute("svg:x1", QString("%1\%").arg(x1));</div>
<div>filters/libmso/ODrawToOdf.cpp(681):
style.addAttribute("svg:y1", QString("%1\%").arg(y1));</div>
<div>filters/libmso/ODrawToOdf.cpp(682):
style.addAttribute("svg:x2", QString("%1\%").arg(x2));</div>
<div>filters/libmso/ODrawToOdf.cpp(683):
style.addAttribute("svg:y2", QString("%1\%").arg(y2));</div>
<div>filters/sheets/xlsx/ChartExport.cpp(240):
style.addProperty( "draw:opacity", QString(
"%1\%" ).arg(
chart()->m_areaFormat->m_foreground.alphaF() *
100.0 ), KoGenStyle::GraphicType );</div>
<div>filters/sheets/xlsx/ChartExport.cpp(302):
style.addProperty( "draw:opacity", QString(
"%1\%" ).arg( areaFormat->m_foreground.alphaF() *
100.0 ), KoGenStyle::GraphicType );</div>
</div>
<div><br>
</div>
<div>Is it okay to just replace "\%" by "%" ?</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Andrius.</div>
</blockquote>
</div>
<br>
<br>
_______________________________________________<br>
calligra-devel mailing list<br>
<a moz-do-not-send="true" href="mailto:calligra-devel@kde.org">calligra-devel@kde.org</a><br>
<a moz-do-not-send="true"
href="https://mail.kde.org/mailman/listinfo/calligra-devel">https://mail.kde.org/mailman/listinfo/calligra-devel</a><br>
<br>
</blockquote>
</div>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
calligra-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:calligra-devel@kde.org">calligra-devel@kde.org</a>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/calligra-devel">https://mail.kde.org/mailman/listinfo/calligra-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>