<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104312/">http://git.reviewboard.kde.org/r/104312/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm impressed. Jan should have the last word, but I'm impressed :-)</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On March 17th, 2012, 11:43 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated March 17, 2012, 11:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The XFig import filter got reimplemented to read files in the XFig 3.2 format and turn them into ODG files.
Large parts of the 3.2 format are supported, so the filter is already quite useful.
Should be also grateful with bad content and not crash on it.
Missing for complete 3.2 support, and will be done by the time (if possible at all):
* multiple pages
* arc objects
* spline objects (only imported as pure polylines, no curves, needs someone who know how to turn x-splines to ODG compatible ones)
* pattern fills
* different arrow types
* info about grouping of objects is dropped, due to problem with z-index being intertwined between different groups</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Loaded successfully a lot of xfig 3.2 files, including the XFig examples in /usr/share/doc/packages/xfig/TheExamples/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/karbon/CMakeLists.txt <span style="color: grey">(396040e)</span></li>
<li>filters/karbon/xfig/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/xfig/XFigDocument.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/xfig/XFigDocument.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/xfig/XFigImportFilter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/xfig/XFigImportFilter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/xfig/XFigOdgWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/xfig/XFigOdgWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/xfig/XFigParser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/xfig/XFigParser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/xfig/XFigStreamLineReader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/xfig/XFigStreamLineReader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/xfig/karbon_xfig_import.desktop <span style="color: grey">(d47427b)</span></li>
<li>filters/karbon/xfig/xfigimport.h <span style="color: grey">(7803f84)</span></li>
<li>filters/karbon/xfig/xfigimport.cc <span style="color: grey">(889e231)</span></li>
<li>filters/karbon/xfig/xfigimport_factory.h <span style="color: grey">(aca3800)</span></li>
<li>filters/karbon/xfig/xfigimport_factory.cc <span style="color: grey">(2a6b691)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104312/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>