<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104268/">http://git.reviewboard.kde.org/r/104268/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 14th, 2012, 8:15 a.m., <b>Sebastian Sauer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104268/diff/1/?file=53071#file53071line698" style="color: black; font-weight: bold; text-decoration: underline;">plugins/chartshape/DataSet.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KDChart::PieAttributes DataSet::pieAttributes() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">697</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">brush</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. That code is never reached when (modelDataDirection == Qt::Horizontal)
2. Note that brush() uses defaultBrush() and not defaultBrush(section). That seems to make a huge difference cause defaultBrush() uses
if ( kdChartModel->dataDirection() == Qt::Vertical )
return defaultDataSetColor( num );
// FIXME: What to return in the other case?
return QBrush();
whereas defaultBrush(section) uses
if ( kdChartModel->dataDirection() == Qt::Horizontal )
return defaultDataSetColor( section );
// Vertically aligned diagrams default to one brush per data set
return defaultBrush();
Better don't ask why the one uses Vertical and the other Horizontal cause I have no clue either... Probably yet another bug?
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the data direction is horizontal,each slice of the pie chart should have a different brush which is handled by brush( int section ) which in some cases will call defaultBrush(section)
and when the data direction is vertical, each dataset will have only one brush, so only calling brush() will handle that case which in some cases will call defaultBrush()
So i've considered both the cases...</pre>
<br />
<p>- Brijesh</p>
<br />
<p>On March 14th, 2012, 6:53 a.m., Brijesh Patel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Inge Wallin and Sebastian Sauer.</div>
<div>By Brijesh Patel.</div>
<p style="color: grey;"><i>Updated March 14, 2012, 6:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FIX : Changing chart type from pie/ring chart to bar chart or vice versa ,doesn't works as expected
i) checks whether the dataDirection is vertical or horizontal and then returns the brush
- This fixes changing chart type from bar chart to pie/ring chart
ii) ensures that axis are saved no matter what be the chart type
- This fixes changing chart type from pie/ring chart to bar chart</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using cstester on some test documents</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/chartshape/DataSet.cpp <span style="color: grey">(1ac5de3)</span></li>
<li>plugins/chartshape/PlotArea.cpp <span style="color: grey">(8f2a9db)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104268/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>