<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104074/">http://git.reviewboard.kde.org/r/104074/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 29th, 2012, 9:38 a.m., <b>Elvis Stansvik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104074/diff/6/?file=51522#file51522line70" style="color: black; font-weight: bold; text-decoration: underline;">libs/odf/KoElementReference.h</a>
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">70</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">enum</span> <span class="n">GenerationOption</span> <span class="p">{</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">71</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">UUID</span> <span class="o">=</span> <span class="mi">0</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">72</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">COUNTER</span> <span class="o">=</span> <span class="mi">1</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">};</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">74</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">75</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">enum</span> <span class="n">SaveOption</span> <span class="p">{</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">XMLID</span> <span class="o">=</span> <span class="mh">0x0</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">77</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">DRAWID</span> <span class="o">=</span> <span class="mh">0x1</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">78</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">TEXTID</span> <span class="o">=</span> <span class="mh">0x2</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">79</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">};</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why not camel case for these enum values?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, that's not a hard-and-fast rule either, but in flake camelcase seems to be used in the odf lib, so I'll change it.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On February 29th, 2012, 9:25 a.m., Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated Feb. 29, 2012, 9:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">draw:id and text:id are deprecated and to be replaced by xml:id. This patch creates a new class KoElementReference that encapsulates loading and saving all three tags, as well as automatically generating a unique id. This is used to make sure that if two items want to save an xml:id on the same element, we only have one, unique tag saved.
I'm not completely happy yet, since parts of KoShapeSavingContext still create numbered, prefixed id's with hidden meanings that are not clearly connect to what the idref actually links to for the master pages. Imo, xml:id should always be guaranteed unique and there should be a clear code-path between the entity that is linked to from an element and the element itself.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing and unittests; on Tuesday I will do a practical test at SKF.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=288644">288644</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/stage/kpr2odf/Filterkpr2odf.cpp <span style="color: grey">(df7079b)</span></li>
<li>filters/stage/pptx/PptxXmlSlideReader.cpp <span style="color: grey">(eaee384)</span></li>
<li>filters/words/docx/DocxXmlDocumentReader.cpp <span style="color: grey">(6aa31f5)</span></li>
<li>filters/words/oowriter/ExportFilter.h <span style="color: grey">(dea56bd)</span></li>
<li>filters/words/oowriter/ExportFilter.cc <span style="color: grey">(ff44e0c)</span></li>
<li>karbon/common/KarbonDocument.cpp <span style="color: grey">(6057a18)</span></li>
<li>krita/ui/flake/kis_shape_layer.cc <span style="color: grey">(8aaca9d)</span></li>
<li>krita/ui/flake/kis_shape_selection.cpp <span style="color: grey">(95ebeb6)</span></li>
<li>libs/flake/KoConnectionShape.cpp <span style="color: grey">(fda3463)</span></li>
<li>libs/flake/KoImageCollection.cpp <span style="color: grey">(27b8260)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(be34b8a)</span></li>
<li>libs/flake/KoShapeLoadingContext.h <span style="color: grey">(87b0830)</span></li>
<li>libs/flake/KoShapeLoadingContext.cpp <span style="color: grey">(0573ddf)</span></li>
<li>libs/flake/KoShapeSavingContext.h <span style="color: grey">(c73a680)</span></li>
<li>libs/flake/KoShapeSavingContext.cpp <span style="color: grey">(46cb477)</span></li>
<li>libs/kopageapp/KoPADocument.cpp <span style="color: grey">(49ac34a)</span></li>
<li>libs/kopageapp/KoPAPage.cpp <span style="color: grey">(fbcf49d)</span></li>
<li>libs/kopageapp/KoPAPastePage.cpp <span style="color: grey">(9fd795e)</span></li>
<li>libs/kopageapp/tests/TestPACopyPastePage.h <span style="color: grey">(363f803)</span></li>
<li>libs/kopageapp/tests/TestPACopyPastePage.cpp <span style="color: grey">(3b023b8)</span></li>
<li>libs/kotext/KoDocumentRdfBase.h <span style="color: grey">(d6f467a)</span></li>
<li>libs/kotext/KoDocumentRdfBase.cpp <span style="color: grey">(7b6b38c)</span></li>
<li>libs/kotext/KoInlineNote.h <span style="color: grey">(91823e9)</span></li>
<li>libs/kotext/KoInlineNote.cpp <span style="color: grey">(897214c)</span></li>
<li>libs/kotext/KoInlineObject.h <span style="color: grey">(8a1d627)</span></li>
<li>libs/kotext/KoTextAnchor.cpp <span style="color: grey">(414b347)</span></li>
<li>libs/kotext/KoTextBlockData.h <span style="color: grey">(cc1528b)</span></li>
<li>libs/kotext/KoTextBlockData.cpp <span style="color: grey">(116b432)</span></li>
<li>libs/kotext/KoTextDrag.cpp <span style="color: grey">(381f4de)</span></li>
<li>libs/kotext/KoTextInlineRdf.h <span style="color: grey">(fd7bb5e)</span></li>
<li>libs/kotext/KoTextInlineRdf.cpp <span style="color: grey">(f449426)</span></li>
<li>libs/kotext/changetracker/KoChangeTracker.h <span style="color: grey">(33c2696)</span></li>
<li>libs/kotext/changetracker/KoChangeTracker.cpp <span style="color: grey">(51b9c5e)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(a15b08e)</span></li>
<li>libs/kotext/opendocument/KoTextWriter.h <span style="color: grey">(fd0689c)</span></li>
<li>libs/kotext/opendocument/KoTextWriter.cpp <span style="color: grey">(56125d3)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.h <span style="color: grey">(c89e895)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.cpp <span style="color: grey">(1dbc8bb)</span></li>
<li>libs/kotext/opendocument/tests/CMakeLists.txt <span style="color: grey">(c386cfb)</span></li>
<li>libs/kotext/opendocument/tests/TestChangeTracking.cpp <span style="color: grey">(665636b)</span></li>
<li>libs/main/rdf/KoDocumentRdf.h <span style="color: grey">(fabc628)</span></li>
<li>libs/main/rdf/KoDocumentRdf.cpp <span style="color: grey">(bfaa9ec)</span></li>
<li>libs/odf/CMakeLists.txt <span style="color: grey">(838d4f6)</span></li>
<li>libs/odf/KoElementReference.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/odf/KoElementReference.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/odf/KoEmbeddedDocumentSaver.cpp <span style="color: grey">(36506ca)</span></li>
<li>libs/odf/KoGenChange.cpp <span style="color: grey">(2cd2d97)</span></li>
<li>libs/odf/KoGenChanges.h <span style="color: grey">(d7b51ee)</span></li>
<li>libs/odf/KoGenChanges.cpp <span style="color: grey">(b64d32d)</span></li>
<li>libs/odf/tests/CMakeLists.txt <span style="color: grey">(ee86038)</span></li>
<li>libs/odf/tests/TestKoElementReference.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/odf/tests/TestKoElementReference.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtCheckBox.cpp <span style="color: grey">(49a82bb)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtLine.cpp <span style="color: grey">(c8a4b9c)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtPicture.cpp <span style="color: grey">(cd3216c)</span></li>
<li>plan/libs/ui/reports/odt/KoSimpleOdtTextBox.cpp <span style="color: grey">(717b867)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp <span style="color: grey">(57aa6fd)</span></li>
<li>stage/part/animations/KPrAnimationBase.cpp <span style="color: grey">(b544485)</span></li>
<li>stage/part/animations/KPrAnimationLoader.cpp <span style="color: grey">(45467dd)</span></li>
<li>stage/part/animations/KPrShapeAnimation.cpp <span style="color: grey">(c7fff3f)</span></li>
<li>tables/part/Doc.cpp <span style="color: grey">(25e3fd3)</span></li>
<li>words/part/KWOdfLoader.cpp <span style="color: grey">(5c568df)</span></li>
<li>words/part/KWOdfWriter.cpp <span style="color: grey">(b998485)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104074/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>