<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104047/">http://git.reviewboard.kde.org/r/104047/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2012, 12:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Comments implemented</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We have made changes to the undo framework in kotexteditor to make things work.
The DeleteCommand has become much more capable as it handles complex selections and bookmarks now
The KoTextEditor.cpp file has been split out into 3 files
The StyleChange commands and shapeAnchoring commands have been adapted to the new frame work</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We have played around with undo redo in all the cases we knew were failing and quite a lot of other tests.
Undo of many things are still not implemented, but that is not really what this is about. It's about the basic undo, and getting the framework right. Fixing undo of individual stuff can always be done as bug fixes
One issue we have noted is insertion of table, whic we believe is a qt bug. We have one last workaround in our minds, but other than that we will just have to wait for a qt fix</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoShapeController.h <span style="color: grey">(abc4358)</span></li>
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(567649b)</span></li>
<li>libs/kotext/KoTextDocument.h <span style="color: grey">(56f55e6)</span></li>
<li>libs/kotext/KoTextDocument.cpp <span style="color: grey">(5608860)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(689051b)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(3c141c7)</span></li>
<li>libs/kotext/KoTextEditor_format.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoTextEditor_p.h <span style="color: grey">(77725f3)</span></li>
<li>libs/kotext/KoTextEditor_undo.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/ChangeAnchorPropertiesCommand.h <span style="color: grey">(4206bb8)</span></li>
<li>libs/kotext/commands/ChangeAnchorPropertiesCommand.cpp <span style="color: grey">(7d4b912)</span></li>
<li>libs/kotext/commands/ChangeStylesCommand.h <span style="color: grey">(accfd31)</span></li>
<li>libs/kotext/commands/ChangeStylesCommand.cpp <span style="color: grey">(b9fa725)</span></li>
<li>libs/kotext/commands/ChangeStylesMacroCommand.cpp <span style="color: grey">(34c3822)</span></li>
<li>libs/kotext/commands/ChangeTrackedDeleteCommand.cpp <span style="color: grey">(89edde1)</span></li>
<li>libs/kotext/commands/DeleteAnchorsCommand.cpp <span style="color: grey">(621829f)</span></li>
<li>libs/kotext/commands/DeleteCommand.h <span style="color: grey">(89b448a)</span></li>
<li>libs/kotext/commands/DeleteCommand.cpp <span style="color: grey">(2a4527d)</span></li>
<li>libs/kotext/commands/TextPasteCommand.cpp <span style="color: grey">(6b9de68)</span></li>
<li>libs/kotext/tests/TestKoTextEditor.cpp <span style="color: grey">(bd15b3a)</span></li>
<li>libs/kundo2/kundo2stack.h <span style="color: grey">(c0539fe)</span></li>
<li>libs/kundo2/kundo2stack.cpp <span style="color: grey">(48d6625)</span></li>
<li>libs/main/rdf/KoSemanticStylesheet.cpp <span style="color: grey">(7853dd0)</span></li>
<li>libs/main/tests/rdf_test.cpp <span style="color: grey">(fb57a5e)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(ddfe47f)</span></li>
<li>plugins/textshape/commands/TextCutCommand.cpp <span style="color: grey">(bdb8eea)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(0005bc6)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(8e00cb6)</span></li>
<li>words/part/dialogs/KWAnchoringProperties.cpp <span style="color: grey">(c742e26)</span></li>
<li>words/part/dialogs/KWFrameDialog.cpp <span style="color: grey">(0fcc0b7)</span></li>
<li>words/part/frames/KWTextFrameSet.cpp <span style="color: grey">(ebd532f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104047/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>