<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104021/">http://git.reviewboard.kde.org/r/104021/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm only answering your question and not considering the patch at all. I think we should just use the qt and kde vars. I can't see any reason why we would disable those things if they are supported by upstream.</pre>
<br />
<p>- C.</p>
<br />
<p>On February 19th, 2012, 4:18 a.m., Sebastian Sauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Sebastian Sauer.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2012, 4:18 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Attached patch is the first draft of the try to get parts of the work done by Mek for the Calligra@Android port ( http://blogs.kde.org/node/4521 ) into master. This is related to the discussion about making dbus optional in Calligra ( http://mail.kde.org/pipermail/calligra-devel/2012-February/003821.html ).
What the first iteration of the patch does is to cherry-pick 4-5 of the patches related to dbus, kntofiy and phonon from the mobile-android-mek branch into my own mobile-android-sebsauer branch. Then I introduced 3 new compiletime options: DBUS, PHONON and KNOTIFY. I then changed the cherry-picked code to not hard-code against Android but use these 3 new compile-time switches to enable/disable the functionality.
Note that this, compile-time switches, are already used in Calligra to enable/disable optionally QT3SUPPORT, GHNS and NEPOMUK. So, the 3 new options do not introduce something new but extend an already established and used concept in Calligra (means to be able to disable certain functionality/dependencies so packager are able to customize Calligra - useful when e.g. building Calligra for another platform like Android or Windows).
What is still missing;
1) use CALLIGRA_NO_DBUS also in all the other parts of Calligra. The Android-port just did disable compiling certain Calligra parts/applications what means no patches where done for some parts/apps. I would need to add more code to handle also those other parts/apps. But since the patch is already rather large I think we can still do that in a second round. That makes it easier to merge patches from master back to Mek's branch :)
2) I am still not sure if it makes really sense to introduce own CALLIGRA_* variables for that or just reuse what Qt/KDE offer (e.g. QT_NO_DBUS). Maybe reusing the Qt/KDE defines would make it easier to understand the defines? Absolute not sure there :-/
So, ideas, wishes, ...? :)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(be6c889)</span></li>
<li>filters/tables/excel/CMakeLists.txt <span style="color: grey">(fbab01c)</span></li>
<li>filters/tables/excel/sidewinder/CMakeLists.txt <span style="color: grey">(6e232ab)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(30c0e8e)</span></li>
<li>libs/main/KoApplication.cpp <span style="color: grey">(c209224)</span></li>
<li>libs/main/KoApplicationAdaptor.h <span style="color: grey">(c17a6fb)</span></li>
<li>libs/main/KoApplicationAdaptor.cpp <span style="color: grey">(aeb7ab5)</span></li>
<li>libs/main/KoDocument.cpp <span style="color: grey">(c790f1e)</span></li>
<li>libs/main/KoDocumentAdaptor.h <span style="color: grey">(b8c1f26)</span></li>
<li>libs/main/KoDocumentAdaptor.cpp <span style="color: grey">(7e099d5)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(a9ab932)</span></li>
<li>libs/main/KoView.cpp <span style="color: grey">(679adb9)</span></li>
<li>libs/main/KoViewAdaptor.h <span style="color: grey">(9406b3d)</span></li>
<li>libs/main/KoViewAdaptor.cpp <span style="color: grey">(6542c35)</span></li>
<li>plan/libs/models/kcalendar/kdatepicker.cpp <span style="color: grey">(8882f3f)</span></li>
<li>plan/libs/models/kcalendar/kdatetable.cpp <span style="color: grey">(9c4e640)</span></li>
<li>plugins/videoshape/FullScreenPlayer.cpp <span style="color: grey">(e88d39a)</span></li>
<li>plugins/videoshape/VideoShapeConfigWidget.cpp <span style="color: grey">(4f5d22e)</span></li>
<li>stage/part/KPrPresentationTool.cpp <span style="color: grey">(4cb0e17)</span></li>
<li>stage/part/KPrPresentationToolAdaptor.h <span style="color: grey">(e0f8def)</span></li>
<li>stage/part/KPrPresentationToolAdaptor.cpp <span style="color: grey">(1b29031)</span></li>
<li>stage/part/KPrView.cpp <span style="color: grey">(1606dfa)</span></li>
<li>stage/part/KPrViewAdaptor.h <span style="color: grey">(081cf76)</span></li>
<li>stage/part/KPrViewAdaptor.cpp <span style="color: grey">(1fd9051)</span></li>
<li>stage/plugins/eventactions/sound/KPrSoundEventAction.cpp <span style="color: grey">(1fbb3f4)</span></li>
<li>tables/CMakeLists.txt <span style="color: grey">(31c74a4)</span></li>
<li>tables/HeaderFooter.cpp <span style="color: grey">(5e0bd48)</span></li>
<li>tables/part/Doc.cpp <span style="color: grey">(25e3fd3)</span></li>
<li>tables/part/View.cpp <span style="color: grey">(e4097ed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104021/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>