<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103779/">http://git.reviewboard.kde.org/r/103779/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4d779e5a576884051aa3c4c6dacf5b4c01681fd4 by C. Boemann to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 24th, 2012, 9:52 a.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2012, 9:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Implement undo of Style changes
Two new methods are introduced: beginEdit() and endEdit() to mark
when the editing happens. At endEdit() the collected changes
are applied to any attached documents like before.
The difference is that it now happens through ChangeStylesMacroCommand
Which in turn uses ChangeStylesCommand
The role of ChangeStylesMacroCommand is to act as a macro plus to
make sure the styles within the stylemanager itself are updated.
The role of ChangeStylesCommand is to update the qtextdocuments.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(6507227)</span></li>
<li>libs/kotext/KoTextDocument.cpp <span style="color: grey">(e551825)</span></li>
<li>libs/kotext/commands/ChangeStylesCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/ChangeStylesCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/ChangeStylesMacroCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/ChangeStylesMacroCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/opendocument/tests/TestChangeTracking.cpp <span style="color: grey">(3aac170)</span></li>
<li>libs/kotext/opendocument/tests/TestLoadStyle.cpp <span style="color: grey">(cafe7d9)</span></li>
<li>libs/kotext/opendocument/tests/TestLoading.cpp <span style="color: grey">(d464480)</span></li>
<li>libs/kotext/styles/ChangeFollower.h <span style="color: grey">(5aa42b0)</span></li>
<li>libs/kotext/styles/ChangeFollower.cpp <span style="color: grey">(5b10a65)</span></li>
<li>libs/kotext/styles/KoCharacterStyle.cpp <span style="color: grey">(9783bc3)</span></li>
<li>libs/kotext/styles/KoParagraphStyle.cpp <span style="color: grey">(b7a5159)</span></li>
<li>libs/kotext/styles/KoStyleManager.h <span style="color: grey">(bf6076c)</span></li>
<li>libs/kotext/styles/KoStyleManager.cpp <span style="color: grey">(c5f645b)</span></li>
<li>libs/kotext/styles/tests/TestListStyle.cpp <span style="color: grey">(47c1137)</span></li>
<li>libs/kotext/tests/TestKoTextEditor.cpp <span style="color: grey">(751c465)</span></li>
<li>libs/textlayout/tests/TestBlockLayout.cpp <span style="color: grey">(bb2cc16)</span></li>
<li>libs/textlayout/tests/TestDocumentLayout.cpp <span style="color: grey">(277178f)</span></li>
<li>libs/textlayout/tests/TestTableLayout.cpp <span style="color: grey">(2bcf0a2)</span></li>
<li>plugins/textshape/dialogs/StyleManager.cpp <span style="color: grey">(2e57137)</span></li>
<li>tables/Map.cpp <span style="color: grey">(cd77d3a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103779/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>