<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103778/">http://git.reviewboard.kde.org/r/103778/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 24th, 2012, 10:19 a.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103778/diff/1/?file=47727#file47727line83" style="color: black; font-weight: bold; text-decoration: underline;">filters/words/html-odf/htmlodfexport.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoFilter::ConversionStatus HTMLOdfExport::convert(const QByteArray &from, const QByteArray &to)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">78</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">82</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// </span><span class="cs">TODO</span><span class="c1"> Reimplement export dialog as new functionality could use it</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe we should get this done then..</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At present, none of the user configurable options presented in the export dialog were being filtered through the rest of the process, the TODO is more a "in future, we may have features we can expose to this".
The Style options presented to the user only produced an empty styles.css file, and nowhere in the XML Stylesheet Transformation is a reference to an external CSS stylesheet set, all the styles are read from the source ODT and embedded in the html file.
Similarly there did not appear to be any similar links with output encoding.
The dialog was removed in order to reduce user confusion/frustration, and to speed the export process. </pre>
<br />
<p>- Stuart</p>
<br />
<p>On January 24th, 2012, 10 a.m., Stuart Dickson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Stuart Dickson.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2012, 10 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improvements to the html-odf export filter.
Added support for: exporting images, tables with merged cells.
Modifications to KoFilter derived class to incorporate Conversion class' convert function and provide improved error checking.
Changes to output styles to improve legibility.
Disabled export filter dialog as it does not have an impact on output, but can be modified in future.
Removing QChar::ObjectReplacementMarkers from appearing in output.
The focus has been on the content and not on styles and there is still improvement in cleaning up the generated output.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing against a couple of sample documents including paragraphs, titles, simple tables and ones with additional merged cells, inline and paragraph anchored images.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/html-odf/CMakeLists.txt <span style="color: grey">(d1bee3f)</span></li>
<li>filters/words/html-odf/ManifestParser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/html-odf/ManifestParser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/html-odf/conversion/converter.xsl <span style="color: grey">(1f01ed6)</span></li>
<li>filters/words/html-odf/convert.h <span style="color: grey">(8cbdd6c)</span></li>
<li>filters/words/html-odf/convert.cpp <span style="color: grey">(226fbd5)</span></li>
<li>filters/words/html-odf/htmlodfexport.h <span style="color: grey">(bff8dec)</span></li>
<li>filters/words/html-odf/htmlodfexport.cpp <span style="color: grey">(5f0606e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103778/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>