<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103778/">http://git.reviewboard.kde.org/r/103778/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks I found no other formatting errors, and if there are i'm sure we can live with them
More disturbing is that I can't get your branch to build:
calligra/filters/words/html-odf/htmlodfexport.cpp:48:21: fatal error: convert.h: No such file or directory
Also as i told you in irc, i think we should get someone else to look at the xls
</pre>
<br />
<p>- C.</p>
<br />
<p>On January 24th, 2012, 1:33 p.m., Stuart Dickson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Stuart Dickson.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2012, 1:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improvements to the html-odf export filter.
Added support for: exporting images, tables with merged cells.
Modifications to KoFilter derived class to incorporate Conversion class' convert function and provide improved error checking.
Changes to output styles to improve legibility.
Disabled export filter dialog as it does not have an impact on output, but can be modified in future.
Removing QChar::ObjectReplacementMarkers from appearing in output.
The focus has been on the content and not on styles and there is still improvement in cleaning up the generated output.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing against a couple of sample documents including paragraphs, titles, simple tables and ones with additional merged cells, inline and paragraph anchored images.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/html-odf/CMakeLists.txt <span style="color: grey">(d1bee3f)</span></li>
<li>filters/words/html-odf/ManifestParser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/html-odf/ManifestParser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/html-odf/conversion/converter.xsl <span style="color: grey">(1f01ed6)</span></li>
<li>filters/words/html-odf/convert.h <span style="color: grey">(8cbdd6c)</span></li>
<li>filters/words/html-odf/convert.cpp <span style="color: grey">(226fbd5)</span></li>
<li>filters/words/html-odf/htmlodfexport.h <span style="color: grey">(bff8dec)</span></li>
<li>filters/words/html-odf/htmlodfexport.cpp <span style="color: grey">(5f0606e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103778/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>