<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103710/">http://git.reviewboard.kde.org/r/103710/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9c4c3bef739950056898bd98cf375be8d8774f0d by Burkhard Lück to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 16th, 2012, 7:23 p.m., Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Marijn Kruisselbrink and Sebastian Sauer.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2012, 7:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FunctionDescription.cpp handles Types "Boolean", "Int", "String", "Any", everything else
is treated as Float type-> that is wrong.
There is also Reference, Array, Bool, String/Numeric, Reference/Array, Error,
FLOAT, int, IntType, Integer, Date, Double -> all treated as Float and displayed with
that type in functions dialog.
1) changed all int/IntType/Integer to the proper Type string "Int" + Bool to "Boolean"
2) removed sebsauers comments, this doesn't break string freeze, the msgs are already in tables.pot
2) added some comments about issues to fixe for 2.5, breaks strings freeze now.
Not all issues mentioned in #290631 are fixed in this patch,
the types Reference, Array, String/Numeric, Reference/Array, Error, Date, Double are still wrong.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=290631">290631</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tables/functions/engineering.xml <span style="color: grey">(a9c5281)</span></li>
<li>tables/functions/financial.xml <span style="color: grey">(e54b400)</span></li>
<li>tables/functions/math.xml <span style="color: grey">(b495861)</span></li>
<li>tables/functions/reference.xml <span style="color: grey">(2446021)</span></li>
<li>tables/functions/statistical.xml <span style="color: grey">(1463231)</span></li>
<li>tables/functions/text.xml <span style="color: grey">(6933622)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103710/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>