<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103677/">http://git.reviewboard.kde.org/r/103677/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Pierre Stirnweiss.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2012, 2:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes issues raised by Zagge and Boemann.
Also fixes the appearance problem Zagge (and others) were experiencing. This was due to the use of a Qt4.8 method of QImage. Method replaced by a pre-4.8 compatible one.
Also, fixes some crash on opening certain documents, now the SimpleCharacterWidget and SimpleParagraphWidget get initialised with the current block and formats.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Merge request.
Merge branch textshape_stylesWidget_pierreSt into master.
The branch provides a replacement for the style selection widgets. The new provided widgets are a subclass of QComboBox.
They provide a style preview both in the main area and in the dropdown menu.
The dropdown menu provides a "show style manager" button, which call the whole style management dialog.
The dropdown also provides a "delete style" button, although this is for the moment disabled/commented out, because deleting a style is not currently really supported.
The combo also allows to create a style based on the current text format if it does not correspond to the original style (ie. the user changed a property).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The functionality exclusively linked to the comboBox seems to be working properly. Some defects have been identified (like no paragraph style is selected at startup), but these are actually outside the scope of this widget and affecting the current widget also.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(94bf433)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(9f242e6)</span></li>
<li>libs/kotext/styles/KoCharacterStyle.h <span style="color: grey">(898ba43)</span></li>
<li>libs/kotext/styles/KoCharacterStyle.cpp <span style="color: grey">(f9e0741)</span></li>
<li>libs/kotext/styles/KoParagraphStyle.h <span style="color: grey">(12ab672)</span></li>
<li>libs/textlayout/CMakeLists.txt <span style="color: grey">(af6d64a)</span></li>
<li>libs/textlayout/FrameIterator.h <span style="color: grey">(c73d580)</span></li>
<li>libs/textlayout/KoStyleThumbnailer.h <span style="color: grey">(8645089)</span></li>
<li>libs/textlayout/KoStyleThumbnailer.cpp <span style="color: grey">(3529bbb)</span></li>
<li>merge_textshape.diff <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(fad7c04)</span></li>
<li>plugins/textshape/TextTool.h <span style="color: grey">(f8de126)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(f6822bd)</span></li>
<li>plugins/textshape/dialogs/SimpleCharacterWidget.h <span style="color: grey">(ad944a5)</span></li>
<li>plugins/textshape/dialogs/SimpleCharacterWidget.cpp <span style="color: grey">(6b2bb66)</span></li>
<li>plugins/textshape/dialogs/SimpleCharacterWidget.ui <span style="color: grey">(e4f6d3b)</span></li>
<li>plugins/textshape/dialogs/SimpleParagraphWidget.h <span style="color: grey">(bc167b4)</span></li>
<li>plugins/textshape/dialogs/SimpleParagraphWidget.cpp <span style="color: grey">(cbfacfe)</span></li>
<li>plugins/textshape/dialogs/SimpleParagraphWidget.ui <span style="color: grey">(b2e9adf)</span></li>
<li>plugins/textshape/dialogs/StylesCombo.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/StylesCombo.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/StylesComboPreview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/StylesComboPreview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/StylesDelegate.h <span style="color: grey">(f5d216f)</span></li>
<li>plugins/textshape/dialogs/StylesDelegate.cpp <span style="color: grey">(d1021f5)</span></li>
<li>plugins/textshape/dialogs/StylesModel.h <span style="color: grey">(dbd17b4)</span></li>
<li>plugins/textshape/dialogs/StylesModel.cpp <span style="color: grey">(94deb24)</span></li>
<li>plugins/textshape/dialogs/StylesWidget.cpp <span style="color: grey">(4f31a01)</span></li>
<li>plugins/textshape/dialogs/TableOfContentsStyleModel.cpp <span style="color: grey">(48ee7c3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103677/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>