<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103677/">http://git.reviewboard.kde.org/r/103677/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still very impressed by your cool work
Compiling now to test it one more time</pre>
 <br />





<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/103677/diff/4/?file=46797#file46797line2131" style="color: black; font-weight: bold; text-decoration: underline;">plugins/textshape/TextTool.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void TextTool::createStyleFromCurrentBlockFormat(QString name)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2123</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">KoParagraphStyle</span> <span class="o">*</span><span class="n">paragraphStyle</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KoParagraphStyle</span><span class="p">(</span><span class="n">m_textEditor</span><span class="p">.</span><span class="n">data</span><span class="p">()</span><span class="o">-></span><span class="n">blockFormat</span><span class="p">(),</span> <span class="n">m_textEditor</span><span class="p">.</span><span class="n">data</span><span class="p">()</span><span class="o">-></span><span class="n">charFormat</span><span class="p">());</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">note to self: we need an autostyl method for parstyles too actually</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/103677/diff/4/?file=46799#file46799line131" style="color: black; font-weight: bold; text-decoration: underline;">plugins/textshape/dialogs/SimpleCharacterWidget.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">SimpleCharacterWidget::SimpleCharacterWidget(TextTool *tool, QWidget *parent)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">125</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="n">QTextCharFormat</span> <span class="n">comparisonFormat</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">= block.charformat
</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/103677/diff/4/?file=46800#file46800line114" style="color: black; font-weight: bold; text-decoration: underline;">plugins/textshape/dialogs/SimpleCharacterWidget.ui</a>
    <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">114</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      <widget class="S<span class="hl">pecialButton</span>" name="char<span class="hl">Frame</span>"></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">114</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      <widget class="S<span class="hl">tylesCombo</span>" name="char<span class="hl">acterStyleCombo</span>"></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">oooh you removed the SpecialButton too

please revert that part</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/103677/diff/4/?file=46803#file46803line121" style="color: black; font-weight: bold; text-decoration: underline;">plugins/textshape/dialogs/SimpleParagraphWidget.ui</a>
    <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">121</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      <widget class="S<span class="hl">pecialButton</span>" name="<span class="hl">blockFrame</span>"></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">121</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      <widget class="S<span class="hl">tylesCombo</span>" name="<span class="hl">paragraphStyleCombo</span>"></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please dont remove the special button
it's very needed</pre>
</div>
<br />



<p>- C.</p>


<br />
<p>On January 15th, 2012, 7:41 p.m., Pierre Stirnweiss wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Pierre Stirnweiss.</div>


<p style="color: grey;"><i>Updated Jan. 15, 2012, 7:41 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Merge request.
Merge branch textshape_stylesWidget_pierreSt into master.
The branch provides a replacement for the style selection widgets. The new provided widgets are a subclass of QComboBox.
They provide a style preview both in the main area and in the dropdown menu.
The dropdown menu provides a "show style manager" button, which call the whole style management dialog.
The dropdown also provides a "delete style" button, although this is for the moment disabled/commented out, because deleting a style is not currently really supported.
The combo also allows to create a style based on the current text format if it does not correspond to the original style (ie. the user changed a property).</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The functionality exclusively linked to the comboBox seems to be working properly. Some defects have been identified (like no paragraph style is selected at startup), but these are actually outside the scope of this widget and affecting the current widget also.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/kotext/KoTextEditor.h <span style="color: grey">(0fc4ff4)</span></li>

 <li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(3ef31d6)</span></li>

 <li>libs/kotext/styles/KoCharacterStyle.h <span style="color: grey">(898ba43)</span></li>

 <li>libs/kotext/styles/KoCharacterStyle.cpp <span style="color: grey">(e575b0d)</span></li>

 <li>libs/kotext/styles/KoParagraphStyle.h <span style="color: grey">(12ab672)</span></li>

 <li>libs/textlayout/CMakeLists.txt <span style="color: grey">(af6d64a)</span></li>

 <li>libs/textlayout/FrameIterator.h <span style="color: grey">(c73d580)</span></li>

 <li>libs/textlayout/KoStyleThumbnailer.h <span style="color: grey">(8645089)</span></li>

 <li>libs/textlayout/KoStyleThumbnailer.cpp <span style="color: grey">(3529bbb)</span></li>

 <li>plugins/textshape/CMakeLists.txt <span style="color: grey">(fad7c04)</span></li>

 <li>plugins/textshape/TextTool.h <span style="color: grey">(17a687b)</span></li>

 <li>plugins/textshape/TextTool.cpp <span style="color: grey">(3ba9d33)</span></li>

 <li>plugins/textshape/dialogs/SimpleCharacterWidget.h <span style="color: grey">(ad944a5)</span></li>

 <li>plugins/textshape/dialogs/SimpleCharacterWidget.cpp <span style="color: grey">(6b2bb66)</span></li>

 <li>plugins/textshape/dialogs/SimpleCharacterWidget.ui <span style="color: grey">(e4f6d3b)</span></li>

 <li>plugins/textshape/dialogs/SimpleParagraphWidget.h <span style="color: grey">(bc167b4)</span></li>

 <li>plugins/textshape/dialogs/SimpleParagraphWidget.cpp <span style="color: grey">(cbfacfe)</span></li>

 <li>plugins/textshape/dialogs/SimpleParagraphWidget.ui <span style="color: grey">(b2e9adf)</span></li>

 <li>plugins/textshape/dialogs/StylesCombo.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/textshape/dialogs/StylesCombo.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/textshape/dialogs/StylesComboPreview.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/textshape/dialogs/StylesComboPreview.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/textshape/dialogs/StylesDelegate.h <span style="color: grey">(f5d216f)</span></li>

 <li>plugins/textshape/dialogs/StylesDelegate.cpp <span style="color: grey">(d1021f5)</span></li>

 <li>plugins/textshape/dialogs/StylesModel.h <span style="color: grey">(dbd17b4)</span></li>

 <li>plugins/textshape/dialogs/StylesModel.cpp <span style="color: grey">(94deb24)</span></li>

 <li>plugins/textshape/dialogs/StylesWidget.cpp <span style="color: grey">(4f31a01)</span></li>

 <li>plugins/textshape/dialogs/TableOfContentsStyleModel.cpp <span style="color: grey">(48ee7c3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103677/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>